Page MenuHomePhabricator
Create Task
Maniphest T370057

[SW] [WtC-M2] [SNL] Replace WiKit's Lookup component by Codex's
Closed, ResolvedPublic
Actions

Description

Problem

The Special:NewLexeme's user interface was composed using a combination of Vue 3 WiKit next elements, such as Lookup. The WiKit design system is now on its deprecation path, as it has been superseded by Codex, the official Wikimedia design system. The utilization of WiKit components is not recommended, and they should be replaced in order to reduce maintenance costs and ensure consistency.

Solution

We have to replace WiKit's Lookup component by the Codex equivalent: cdx-lookup (Link to demo). In order to preserve its validation behavior, Lookup needs to be wrapped within the Field component (see demo). Field also provides a label for the components it wraps.

image.png (1×2 px, 439 KB)

The WiKit Lookup component is used by the following Special:NewLexeme components:

Acceptance criteria
  • The WiKit Lookup component used in the Special:NewLexeme is replaced by its Codex equivalent, Lookup + Field

Details

SubjectRepoBranchLines +/-
Bump special-new-lexememediawiki/extensions/WikibaseLexememaster+3 -3
Update Codex from v1.13.1 to v1.14.0mediawiki/coremaster+574 -144
Lookup: Add ARIA `role`` to no result Lookup itemdesign/codexmain+19 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arian_Bozorg created this task.Jul 15 2024, 2:52 PM
Arian_Bozorg mentioned this in T370051: [SW] [WtC-M2] [SNL] [EPIC] Replace legacy components by available Codex components.
Arian_Bozorg renamed this task from [WtC-M2] [SNL] Replace WiKit's Lookup component by Codex's to [SW] [WtC-M2] [SNL] Replace WiKit's Lookup component by Codex's.Jul 16 2024, 1:41 PM
Arian_Bozorg moved this task from Incoming to UX Backlog on the Wikidata Dev Team board.
• Sarai-WMDE updated the task description. (Show Details)Jul 16 2024, 6:04 PM
• Sarai-WMDE updated the task description. (Show Details)Jul 25 2024, 3:28 PM
• Sarai-WMDE updated the task description. (Show Details)Jul 25 2024, 4:06 PM
• Sarai-WMDE mentioned this in T369510: [SW] [WtC-M2] [SNL] Use Codex tokens and custom spacing variables in the Special:NewLexeme layout.Jul 25 2024, 5:49 PM
• Sarai-WMDE updated the task description. (Show Details)Jul 26 2024, 6:47 PM
• Sarai-WMDE updated the task description. (Show Details)
Arian_Bozorg moved this task from UX Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Sep 10 2024, 9:07 AM
ArthurTaylor subscribed.Sep 19 2024, 10:37 AM

See T360138

ArthurTaylor claimed this task.Sep 20 2024, 9:06 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
Michael subscribed.Sep 24 2024, 2:44 PM

Hi, I noticed this moving and wanted to let you know about T362650: Lookup: address usability issues. That task might soonish result in minor changes to the behavior of Codex Lookups, though I cannot say whether those changes will be relevant to this Special:NewLexeme usecase.

gerritbot added a comment.Sep 30 2024, 11:38 AM

Change #1076719 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[design/codex@main] Add aria-role to empty lookup result item

https://gerrit.wikimedia.org/r/1076719

gerritbot added a project: Patch-For-Review.Sep 30 2024, 11:38 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Oct 2 2024, 10:45 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE added a subtask: T376024: Add missing aria role to "no results found" slot of Lookup component.Oct 2 2024, 12:39 PM
Lucas_Werkmeister_WMDE subscribed.

Pull request: https://github.com/wmde/new-lexeme-special-page/pull/773

Lucas_Werkmeister_WMDE claimed this task.Oct 2 2024, 12:48 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Oct 2 2024, 9:02 PM

Change #1076719 merged by jenkins-bot:

[design/codex@main] Lookup: Add ARIA `role`` to no result Lookup item

https://gerrit.wikimedia.org/r/1076719

gerritbot added a comment.Oct 16 2024, 3:42 PM

Change #1080747 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.13.1 to v1.14.0

https://gerrit.wikimedia.org/r/1080747

PatchDemoBot added a comment.Oct 16 2024, 3:53 PM

Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/ff2c211f43/wiki/Main Page

gerritbot added a comment.Oct 16 2024, 5:26 PM

Change #1080747 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.13.1 to v1.14.0

https://gerrit.wikimedia.org/r/1080747

egardner closed subtask T376024: Add missing aria role to "no results found" slot of Lookup component as Resolved.Oct 16 2024, 6:10 PM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Oct 23 2024, 12:30 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
AudreyPenven_WMDE claimed this task.Oct 24 2024, 3:06 PM
AudreyPenven_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Oct 24 2024, 4:33 PM
AudreyPenven_WMDE subscribed.
AudreyPenven_WMDE moved this task from In Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Oct 24 2024, 4:37 PM
ArthurTaylor added a subtask: T379595: [WtC-M2] [SNL] Codex Lookup implementation of SpellingVariantInput drops input.Tue, Nov 12, 8:41 AM
karapayneWMDE closed subtask T379595: [WtC-M2] [SNL] Codex Lookup implementation of SpellingVariantInput drops input as Resolved.Mon, Nov 18, 8:39 AM
Arian_Bozorg added a subscriber: Charlie_WMDE.Tue, Nov 19, 2:18 PM

Tagging @Charlie_WMDE for verification

Charlie_WMDE added a comment.Wed, Nov 27, 1:18 PM

hey all, i'm struggling to find the netlify link to review the changes. could someone provide it for me please? thanks!

Lucas_Werkmeister_WMDE added a comment.Wed, Nov 27, 1:23 PM

This is already deployed to production, it’s probably best to verify it there: https://www.wikidata.org/wiki/Special:NewLexeme

Charlie_WMDE added a comment.Wed, Nov 27, 3:27 PM

Hey all! Everything looks good to me except that the labels aren't bolded. Looking at the codex specs, I gather that in the case of Label + description, the label should be bold. Is that something that you can still add?

Lucas_Werkmeister_WMDE moved this task from Product Verification to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Wed, Nov 27, 4:00 PM

Huh, apparently that’s just something we have to opt into. Thanks for noticing it!

https://github.com/wmde/new-lexeme-special-page/pull/808

Lucas_Werkmeister_WMDE added a comment.Wed, Nov 27, 4:01 PM

Also, I don’t know if it’s related to the Codex migration, but this seems highly unfortunate 😬

image.png (831×884 px, 109 KB)

(For searchability: that’s “⧼wikibase-lexeme-language-name-bat-smg⧽ (bat-smg)” etc.)

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Thu, Nov 28, 8:24 AM
ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Thu, Nov 28, 8:48 AM

Change #1098880 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Bump special-new-lexeme

https://gerrit.wikimedia.org/r/1098880

ArthurTaylor moved this task from Product Verification to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Thu, Nov 28, 8:49 AM
gerritbot added a comment.Thu, Nov 28, 9:33 AM

Change #1098880 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Bump special-new-lexeme

https://gerrit.wikimedia.org/r/1098880

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Thu, Nov 28, 11:43 AM

Alright, the bold version can be seen on https://wikidata.beta.wmflabs.org/wiki/Special:NewLexeme now (or in production next week).

Charlie_WMDE added a comment.Thu, Nov 28, 3:25 PM

looks great, thanks!

Arian_Bozorg closed this task as Resolved.Tue, Dec 3, 9:23 AM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE added a comment.Tue, Dec 3, 10:25 AM
In T370057#10362243, @Lucas_Werkmeister_WMDE wrote:

Also, I don’t know if it’s related to the Codex migration, but this seems highly unfortunate 😬

image.png (831×884 px, 109 KB)

(For searchability: that’s “⧼wikibase-lexeme-language-name-bat-smg⧽ (bat-smg)” etc.)

Now reported at T381370: WikibaseLexeme shows language codes without language names in spelling variant dropdown.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits