Maniphest T372119

[S] Crash when viewing revision history
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	TheresNoTime
	Aug 8 2024, 11:47 PM

Tags

Referenced Files

	F57187791: IMG_0036.gif
	Aug 8 2024, 11:47 PM

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Log in to the iOS (iPad) Wikipedia app
Open an article
Tap "..." and then "Article revision history"

What happens?:
App crashes

What should have happened instead?:
Revision history displayed

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

iPadOS 17.5.1 (21F90)
App 7.5.6 (3814)

IMG_0036.gif (914×600 px, 1 MB)

(above gif cuts off a little early but might be helpful to show behaviour?)

Engineering notes:
Fix crash in HtmlUtils.stringFromHTML
Xcode is reporting some crashes in the HtmlUtils.stringFromHTML method. Stack trace indicates it's from PageHistoryViewController.configure(cell:for:at:) method in 7.5.6 (3814). We also see it from the WMFWatchlistViewModel.ItemViewModel.comment.getter method in 7.5.7 (3841).

Related Objects

Mentioned In: T372096: Release 7.5.7

Event Timeline

TheresNoTime created this task.Aug 8 2024, 11:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2024, 11:47 PM

TheresNoTime updated the task description. (Show Details)Aug 8 2024, 11:48 PM

+2 more reports

On the iPad app 7.5.6 (3814) on iPad OS 15.8.2, iPad mini4 MK8D2B/A I am getting crashes when viewing Edit History. This does not happen on all pages. Examples of pages where it happens every time reproducibly:

Andree Melly
Guthrie Govan
Ionosphere

And where it does not appear to ever happen:

Dew point
Tog (unit)

Bug: tapping on “revision history” on an article crashes app
Tapping on the “Article revision history” button will crash the app. I noticed this bug when looking at this page in the app : https://en.wikipedia.org/wiki/Stephen_Nedoroscik

Steps to reproduce:

Open app

Go to article

Tap on three dots in bottom right to show context menu

Tap on article revision history

Version: WikipediaApp/7.5.6.3814 (iOS 17.6; Phone)

HNordeenWMF renamed this task from Crash when viewing revision history on iPad to Crash when viewing revision history .Aug 12 2024, 4:12 PM

HNordeenWMF updated the task description. (Show Details)Aug 12 2024, 4:23 PM

HNordeenWMF merged a task: T372296: Fix crash in HtmlUtils.stringFromHTML.

HNordeenWMF added a subscriber: Tsevener.

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.Aug 12 2024, 4:25 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Engineering Sync on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).Aug 12 2024, 4:31 PM

Try to pick up in the next sprint, before the nice-to-have items

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.Aug 13 2024, 5:29 PM

Tsevener renamed this task from Crash when viewing revision history to [S] Crash when viewing revision history .Aug 13 2024, 6:32 PM

Seddon moved this task from Needs Engineering Sync to Ready for Next Sprint on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 19 2024, 10:37 AM

Also reports of seeing this crash in Notifications Center and Watchlist.

Tsevener mentioned this in T372096: Release 7.5.7.Aug 20 2024, 2:25 PM

Tsevener claimed this task.Aug 23 2024, 5:24 PM

Tsevener moved this task from Ready for Next Sprint to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4939

Tsevener moved this task from Ready for Development to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 23 2024, 5:48 PM

+1 more report through the support email:

Prostate cancer - Version history - Scrolling to the end: always crashes
Version: WikipediaApp/7.5.6.3814 (iOS 17.6; Phone)

Oleitner subscribed.Aug 25 2024, 5:15 PM

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4939

Mazevedo removed Tsevener as the assignee of this task.Aug 26 2024, 1:44 PM

Mazevedo moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Mazevedo moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 27 2024, 2:16 PM

Mazevedo moved this task from Needs QA signoff to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 27 2024, 4:05 PM

Mazevedo moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 28 2024, 5:37 PM

Fixed on 7.5.8 (3979)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 30 2024, 4:46 PM

HNordeenWMF closed this task as Resolved.Sep 5 2024, 11:29 PM