Page MenuHomePhabricator
Create Task
Maniphest T374770

Non-autoconfirmed users get no CAPTCHA and cannot save external links with DiscussionTools new topic tool
Open, Needs TriagePublicBUG REPORT
Actions

Description

Non-autoconfirmed users cannot save external links with the new topic tool from DiscussionTools.
If you write an external link and click the blue "Add topic" button then it turns grey for a second and there are moving diagonal lines in the text area. Nothing else happens. There is no CAPTCHA or error message and nothing is saved.

It was reported 9 September 2024 at https://en.wikipedia.org/w/index.php?title=Wikipedia:Teahouse&oldid=1245763610#Some_of_my_students_cannot_post_external_links_to_my_talk_page

Screenshot from https://en.wikipedia.org/wiki/Wikipedia_talk:Sandbox attached. Made in Firefox with Vector 2022 in the non-autoconfirmed account https://en.wikipedia.org/wiki/User:PrimeHunter3. The tested link is https://example.com. The same happens for IP's.

External link error.png (611×958 px, 56 KB)

Captchas appear as expected with the reply tool.

Details

SubjectRepoBranchLines +/-
Don't startPoll if there's not a subscribable heading, i.e. New Topicmediawiki/extensions/DiscussionToolsmaster+7 -0
Customize query in gerrit

Event Timeline

PrimeHunter created this task.Sep 14 2024, 11:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2024, 11:48 PM
Johannnes89 subscribed.Sep 15 2024, 9:04 AM
Bugreporter added a project: ConfirmEdit (CAPTCHA extension).Sep 15 2024, 1:29 PM
Ciencia_Al_Poder subscribed.Sep 15 2024, 1:36 PM
DLynch renamed this task from Non-autoconfirmed users get no CAPTCHA and cannot save external links with DiscussionTools to Non-autoconfirmed users get no CAPTCHA and cannot save external links with DiscussionTools new topic tool.Sep 17 2024, 12:11 AM
DLynch updated the task description. (Show Details)
DLynch subscribed.Sep 17 2024, 12:24 AM

This was introduced by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/1068047

It was actually breaking things slightly more expansively than captchas -- any save errors from the new topic tool would just not be shown. Captchas are just the most easily-triggerable save error.

gerritbot added a comment.Sep 17 2024, 12:26 AM

Change #1073304 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Don't startPoll if there's not a subscribable heading, i.e. New Topic

https://gerrit.wikimedia.org/r/1073304

gerritbot added a project: Patch-For-Review.Sep 17 2024, 12:26 AM
DLynch claimed this task.Sep 17 2024, 12:28 AM
DLynch added a project: Editing-team (Kanban Board).
DLynch moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
• matmarex subscribed.Sep 17 2024, 12:38 AM
gerritbot added a comment.Sep 17 2024, 12:50 AM

Change #1073304 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't startPoll if there's not a subscribable heading, i.e. New Topic

https://gerrit.wikimedia.org/r/1073304

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 17 2024, 12:56 AM
DLynch added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 17 2024, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2024, 1:30 AM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 20 2024, 1:34 AM
Ryasmeen edited projects, added Verified; removed Editing QA.
Ryasmeen edited projects, added Editing QA; removed Verified.Sep 20 2024, 1:41 AM
Ryasmeen subscribed.Sep 20 2024, 1:52 AM

Checked on Beta cluster, looks like with new topic tool a Non-autoconfirmed user is still not getting CAPTCHA when adding an external link and but it is getting saved.

kostajh subscribed.Sep 20 2024, 9:07 AM

Non-autoconfirmed user is still not getting CAPTCHA when adding an external link and but it is getting saved.

This sounds like an important thing to fix.

• matmarex added a comment.Sep 20 2024, 10:11 AM

In our production (and beta cluster) configuration, you'll only get a CAPTCHA if adding a new external link (linking to a website that isn't yet linked from the page you're editing). That means you should have seen a CAPTCHA when making this edit, but not when making this, this or this one. Do you recall if that's what happened, or can you test it again please? I just tested and got a CAPTCHA when adding a new external link using the new topic tool (I didn't save the edit).

Ryasmeen edited projects, added Verified; removed Editing QA.Tue, Sep 24, 9:22 PM
In T374770#10163747, @matmarex wrote:

In our production (and beta cluster) configuration, you'll only get a CAPTCHA if adding a new external link (linking to a website that isn't yet linked from the page you're editing). That means you should have seen a CAPTCHA when making this edit, but not when making this, this or this one. Do you recall if that's what happened, or can you test it again please? I just tested and got a CAPTCHA when adding a new external link using the new topic tool (I didn't save the edit).

I re-tested it. Yes, when I am adding a new external link I am getting a CAPTCHA as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits