Page MenuHomePhabricator
Create Task
Maniphest T70082

UploadWizard fails to show error if in multiple uploads, an individualized license is left blank
Closed, ResolvedPublic
Actions

Description

Author: neilk

Description:
To replicate:

  • Upload two or more photos.
  • At the licensing step, ask to provide details for each item individually.
  • Leave at least one item unlicensed (i.e. don't click anything in the license area)
  • Press "Next"
  • The button does not take you to the next step, but also does not show any errors. Nothing happens.

Version: unspecified
Severity: normal

Details

Reference
bz68082
SubjectRepoBranchLines +/-
mw.UploadWizardDeed: Do not assume that deed is always setmediawiki/extensions/UploadWizardmaster+7 -4
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
• bzimport added a project: UploadWizard.
• bzimport set Reference to bz68082.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jul 16 2014, 1:05 AM
• bzimport added a comment.Jul 16 2014, 1:09 AM

neilk wrote:

However, the upload itself isn't stalled - the user can fix the problem and then proceed. Presumably the issue is that the validator cannot deal with a completely blank UploadWizardDeed any more. Also, probably the default license should be applied to the multiple deeds.

Steinsplitter added a comment.Jul 16 2014, 12:00 PM

Which browser do you use?

• bzimport added a comment.Jul 16 2014, 4:06 PM

neilk wrote:

(In reply to Steinsplitter from comment #2)

Which browser do you use?

I'm seeing it in Chrome 35 and Firefox 30.

• Gilles triaged this task as Medium priority.Nov 24 2014, 2:35 PM
• Gilles subscribed.
• Gilles added a project: Multimedia.Nov 24 2014, 3:14 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:35 PM
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:35 PM
matmarex claimed this task.Nov 2 2015, 1:36 PM
gerritbot subscribed.Nov 2 2015, 1:37 PM

Change 249893 had a related patch set uploaded (by Bartosz Dziewoński):
mw.UploadWizardDeed: Do not assume that deed is always set

https://gerrit.wikimedia.org/r/249893

gerritbot added a project: Patch-For-Review.Nov 2 2015, 1:37 PM
gerritbot added a comment.Nov 2 2015, 8:14 PM

Change 249893 merged by jenkins-bot:
mw.UploadWizardDeed: Do not assume that deed is always set

https://gerrit.wikimedia.org/r/249893

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 2 2015, 9:00 PM
matmarex closed this task as Resolved.Nov 3 2015, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits