Advanced media dialog is shown with horizontal scrollbars because button labels don't fit
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	matmarex
	Oct 17 2014, 3:45 PM

Description

Advanced media dialog is shown with horizontal scrollbars because button labels don't fit.

Screen Shot 2018-03-22 at 2.24.20 PM.png (430×710 px, 48 KB)

Details

Reference: bz72187

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWMediaDialog: Use dropdown for image type selector	mediawiki/extensions/VisualEditor	master	+8 -7

Customize query in gerrit

Related Objects

Mentioned Here: T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons
T190462: Image Type option "Basic" overlaps with the vertical scrollbar inside the media settings dialog after the new icon set change

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:46 AM

• bzimport added a project: VisualEditor-EditingTools.

• bzimport set Reference to bz72187.

matmarex created this task.Oct 17 2014, 3:45 PM

Can we improve the translations?

Not really.

Well, given that we're replacing this dialog with a new design which will be wider (as we'll have now drawer), and it's only in the "advanced" section, it's maybe not worth worrying for now? Eh.

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:04 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:20 PM

This is still a problem with the new dialog and the new design, I updated the screenshot.

Finally, this has also become a problem in English.

Reciting myself from T190462:

No regression to my knowledge. We once discussed a compromise as solution in T112982 with Ed being against the proposal. We'd need a constructive idea…

I was hoping for inputs by @Esanders – if spilling one button on next line seems insufficient, how about calculating the available horizontal size and putting all of them underneath each other when above?

• Elitre awarded a token.Mar 27 2018, 10:23 AM

Change 422138 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog: Use dropdown for image type selector

https://gerrit.wikimedia.org/r/422138

gerritbot added a project: Patch-For-Review.Mar 27 2018, 12:41 PM

Ryasmeen awarded a token.Mar 28 2018, 12:19 AM

Change 422138 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog: Use dropdown for image type selector

https://gerrit.wikimedia.org/r/422138

matmarex claimed this task.Apr 5 2018, 11:51 AM

matmarex edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.

matmarex moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 12:00 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Media; removed VisualEditor-EditingTools.Apr 5 2018, 4:19 PM

Ryasmeen added a project: Verified.Apr 5 2018, 10:04 PM

That'll do it.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 9 2018, 3:32 PM

	F15974499: Screen Shot 2018-03-22 at 2.24.20 PM.png
	Mar 26 2018, 11:43 PM

	F31574: pasted_file
	Jan 24 2015, 10:01 AM

Advanced media dialog is shown with horizontal scrollbars because button labels don't fitClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Advanced media dialog is shown with horizontal scrollbars because button labels don't fit
Closed, ResolvedPublic1 Estimated Story Points
Actions