Page MenuHomePhabricator
Create Task
Maniphest T89923

Categories become "detached item" after clicking 'Cancel' button
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When following the steps - do not click on 'Apply Changes button'!

  1. In VE-> Categories. Add three categories
  2. Click on the drop-down arrow to delete two of them.
  3. Click 'Cancel'
  4. Re-open the box and one of the categories is still there
  5. Try to delete the remaining category - Uncaught TypeError is displayed:

Error: Cannot remove detached item
remove (undefined, line 380)
onRemoveCategory
emit
onRemoveCategory
emit
onClick
(anonymous function) ([native code], line 0)
dispatch (load.php, line 65)
handle (load.php, line 60)

Or
Uncaught TypeError: Cannot read property 'metaItem' of undefined ve.ui.MWCategoryWidget.onRemoveCategoryVM636:7 oo.EventEmitter.emit ve.ui.MWCategoryPopupWidget.onRemoveCategoryVM636:7 oo.EventEmitter.emitOO.ui.ButtonElement.onClickVM636:128 OO.ui.ButtonWidget.onClickload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150218T2…:65 jQuery.event.dispatchload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150218T2…:60 jQuery.event.add.elemData.handle

After clicking the 'Apply button' at any step(even at the last one when it looks like a category cannot be removed), all come back to normal workflow and all categories get deleted.

Details

SubjectRepoBranchLines +/-
MWCategoryWidget: Remove entries from this.categories when appropriatemediawiki/extensions/VisualEditormaster+9 -0
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Feb 19 2015, 2:03 AM
Etonkovidova raised the priority of this task from to Medium.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2015, 2:03 AM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Feb 21 2015, 8:11 PM
Krenair subscribed.Feb 26 2015, 11:07 PM

I can't reproduce step 4 - I reopened the categories dialog, but the categories are still all gone.

Krenair added a comment.Feb 26 2015, 11:09 PM

Although I can 'Move x category here' on one of the categories which I cancelled addition of, which does error "Uncaught Error: Cannot remove detached item"

Krenair added a project: VisualEditor-MediaWiki.Feb 26 2015, 11:09 PM
gerritbot subscribed.Feb 27 2015, 10:08 PM

Change 193496 had a related patch set uploaded (by Alex Monk):
MWCategoryWidget: Remove entries from this.categories when appropriate

https://gerrit.wikimedia.org/r/193496

gerritbot added a project: Patch-For-Review.Feb 27 2015, 10:08 PM
Krenair claimed this task.Feb 27 2015, 10:24 PM
Krenair set Security to None.
Jdforrester-WMF closed this task as Resolved.Feb 28 2015, 12:59 AM
Jdforrester-WMF added a project: WMF-deploy-2015-03-04_(1.25wmf20).
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Feb 28 2015, 1:00 AM

Change 193496 merged by jenkins-bot:
MWCategoryWidget: Remove entries from this.categories when appropriate

https://gerrit.wikimedia.org/r/193496

Krenair mentioned this in rEVED9246fcd2ff7d: MWCategoryWidget: Remove entries from this.categories when appropriate.Feb 28 2015, 1:00 AM
Etonkovidova added a comment.Mar 3 2015, 9:10 PM

Verified the fix in beta.

Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 3 2015, 11:28 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 4 2015, 3:17 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 4 2015, 3:19 PM
Krenair mentioned this in T76715: Same Category get added multiple times ,for every change in “Sort this page by default as” value. .Mar 4 2015, 4:17 PM
Etonkovidova added a project: Verified-in-Phase0.Mar 5 2015, 12:15 AM
Etonkovidova added a comment.Mar 11 2015, 10:58 PM

Re-opening: the issue is present in beta, test2, and production - attached the screencast. The issue is not too serious- those 'detached' categories are not saved.

Category_cannot_remove_detached_item.mov7 MBDownload

As Alex noticed - re-arranging the categories(dragging them) - and then deleting them causes errors when the Options-Categories dialog is re-opened.

The clarified steps:

  1. Add three categories - AA, BB, CC
  2. Move CC category - insert it in front of BB, then in front of AA (the sequence seems to be important)
  3. Delete AA and BB - click 'Cancel'
  4. Re-open Categories - CC category remains displayed.
  5. Click CC to delete -

Error: Cannot remove detached item
and sometime

TypeError: this.categories[name] is undefined

Etonkovidova reopened this task as Open.Mar 11 2015, 10:59 PM
Etonkovidova removed a project: Verified-in-Phase0.
Etonkovidova added a comment.Mar 16 2015, 5:48 PM

Marking this issues as 'Closed' again.

The bug about re-arranging categories(drag-and-drop) is opened as https://phabricator.wikimedia.org/T9286 "Re-arranged(drag-drop) Categories become "detached item" after clicking 'Cancel' button".

Etonkovidova closed this task as Resolved.Mar 16 2015, 5:48 PM
Etonkovidova added a project: Verified-in-Phase2.
Krenair added a comment.Mar 17 2015, 9:49 PM
In T89923#1122157, @Etonkovidova wrote:

The bug about re-arranging categories(drag-and-drop) is opened as https://phabricator.wikimedia.org/T9286 "Re-arranged(drag-drop) Categories become "detached item" after clicking 'Cancel' button".

Fixed link: T92861

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits