Page MenuHomePhabricator
Feed Advanced Search

Apr 23 2024

Pppery renamed T363177: WikiSEO: testGetDescriptionTENotLoaded test is failing from WikiSEO: to WikiSEO: testGetDescriptionTENotLoaded test is failing.
Apr 23 2024, 3:30 PM · ci-test-error, WikiSEO
taavi created T363177: WikiSEO: testGetDescriptionTENotLoaded test is failing.
Apr 23 2024, 3:14 PM · ci-test-error, WikiSEO

Mar 14 2024

Porplemontage renamed T360126: Auto description not set after revert from Auto description not set on revert to Auto description not set after revert.
Mar 14 2024, 4:13 PM · WikiSEO
Porplemontage created T360126: Auto description not set after revert.
Mar 14 2024, 4:08 PM · WikiSEO

Nov 7 2023

alistair3149 updated subscribers of T350721: Consider adding speakable to JSON-LD.
Nov 7 2023, 7:05 PM · WikiSEO
alistair3149 updated the task description for T350721: Consider adding speakable to JSON-LD.
Nov 7 2023, 7:04 PM · WikiSEO
alistair3149 created T350721: Consider adding speakable to JSON-LD.
Nov 7 2023, 7:03 PM · WikiSEO

Oct 20 2023

Aloist added a watcher for WikiSEO: Aloist.
Oct 20 2023, 1:58 PM

Sep 18 2023

Aklapper added a parent task for T295065: Security Readiness Review For WikiSEO: T346590: Install Extension:WikiSEO on the English Wiktionary.
Sep 18 2023, 8:23 AM · WikiSEO, secscrum, Security, Application Security Reviews

Jul 12 2023

Aklapper changed the edit policy for WikiSEO.
Jul 12 2023, 11:02 AM

Jun 30 2023

Octfx added a comment to T337907: Composer details are wrong.

I stopped tagging with the move to REL branches.

Jun 30 2023, 8:39 AM · WikiSEO
Samwilson added a comment to T337907: Composer details are wrong.

It looks like there's a bunch of work since 2.6.6; is that not ready for release?

Jun 30 2023, 8:18 AM · WikiSEO
Octfx closed T337907: Composer details are wrong as Resolved.
Jun 30 2023, 6:26 AM · WikiSEO
Octfx added a comment to T337907: Composer details are wrong.

Whoops, thanks for the reminder!
Just pushed the tag.

Jun 30 2023, 6:26 AM · WikiSEO
Samwilson added a comment to T337907: Composer details are wrong.

@Octfx I think this still needs a new release tagged. The latest in the Gerrit repo is still 2.6.5.

Jun 30 2023, 12:16 AM · WikiSEO

Jun 29 2023

Octfx closed T320599: Add support for dc.identifier.wikidata meta tag as Resolved.
Jun 29 2023, 9:22 AM · WikiSEO
Octfx closed T330497: wgWikiSeoEnableAutoDescription and TextExtracts as Resolved.
Jun 29 2023, 9:21 AM · WikiSEO
Octfx closed T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO as Resolved.
Jun 29 2023, 9:21 AM · WikiSEO, PageImages
Octfx closed T317439: WikiSEO doesn't show svg logo from $wgLogos as Resolved.
Jun 29 2023, 9:21 AM · WikiSEO
Octfx closed T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError as Resolved.
Jun 29 2023, 9:19 AM · Patch-Needs-Improvement, WikiSEO

Jun 1 2023

Maintenance_bot removed a project from T337907: Composer details are wrong: Patch-For-Review.
Jun 1 2023, 8:10 AM · WikiSEO
gerritbot added a comment to T337907: Composer details are wrong.

Change 925651 merged by jenkins-bot:

[mediawiki/extensions/WikiSEO@master] Fix Composer name and remove version number

https://gerrit.wikimedia.org/r/925651

Jun 1 2023, 7:54 AM · WikiSEO
Samwilson added a comment to T337907: Composer details are wrong.

I think you might have to make a new tag to force it to update, maybe one higher than 2.6.6 because that one was already tagged in the GitHub repo but wasn't tagged in the Gerrit one.

Jun 1 2023, 7:48 AM · WikiSEO
Octfx added a comment to T337907: Composer details are wrong.

Never thought of this
I've updated the source on packagist, many thanks!

Jun 1 2023, 7:43 AM · WikiSEO
Samwilson added a comment to T337907: Composer details are wrong.

Ah, that makes sense. Good idea! But there's definitely some varying opinions around whether we should even use Composer to install extensions, so it might be hard to convince people to register that package name.

Jun 1 2023, 7:28 AM · WikiSEO
Octfx added a comment to T337907: Composer details are wrong.

I was trying to get wikiseo into the mediawiki packagist namespace, but to no avail.

Jun 1 2023, 7:18 AM · WikiSEO
gerritbot added a project to T337907: Composer details are wrong: Patch-For-Review.
Jun 1 2023, 7:09 AM · WikiSEO
gerritbot added a comment to T337907: Composer details are wrong.

Change 925651 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiSEO@master] Fix Composer name and remove version number

https://gerrit.wikimedia.org/r/925651

Jun 1 2023, 7:09 AM · WikiSEO
Samwilson created T337907: Composer details are wrong.
Jun 1 2023, 7:05 AM · WikiSEO

Apr 22 2023

Ciencia_Al_Poder added a comment to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.

Such a configuration exists on MediaWiki 1.39, added to solve T217307

Apr 22 2023, 1:15 PM · WikiSEO, PageImages

Feb 25 2023

RESTARTTT added a comment to T330497: wgWikiSeoEnableAutoDescription and TextExtracts.

This is to remove the infobox

Feb 25 2023, 8:16 AM · WikiSEO
RESTARTTT added a comment to T330497: wgWikiSeoEnableAutoDescription and TextExtracts.

I think I figured out what to do is to configure $wgExtractsRemoveClasses. I wrote this config, but nothing happens.

Feb 25 2023, 8:15 AM · WikiSEO

Feb 24 2023

RESTARTTT added a comment to T330497: wgWikiSeoEnableAutoDescription and TextExtracts.

I figured out what was causing it. On pages where templates are used (cards) that's where the description is not shown. Can I tell it to ignore templates?

Feb 24 2023, 2:55 PM · WikiSEO
RESTARTTT added a comment to T330497: wgWikiSeoEnableAutoDescription and TextExtracts.

I on Description2 and check page with ?action=info. And:

Feb 24 2023, 2:51 PM · WikiSEO
RESTARTTT added a comment to T330497: wgWikiSeoEnableAutoDescription and TextExtracts.

Thanks for the report. When WikiSeoEnableAutoDescription is active, after a page has been edited, WikiSEO tries to generate a description by calling TextExtracts.
With Extension:Description2 deactivated can you check any of your pages with ?action=info and report if a description prop is listed there?

I myself use WikiSeoEnableAutoDescription = true on MediaWiki 1.39 and can confirm that it is working.

Feb 24 2023, 2:43 PM · WikiSEO
Octfx added a comment to T330497: wgWikiSeoEnableAutoDescription and TextExtracts.

Thanks for the report. When WikiSeoEnableAutoDescription is active, after a page has been edited, WikiSEO tries to generate a description by calling TextExtracts.
With Extension:Description2 deactivated can you check any of your pages with ?action=info and report if a description prop is listed there?

Feb 24 2023, 2:31 PM · WikiSEO
RESTARTTT created T330497: wgWikiSeoEnableAutoDescription and TextExtracts.
Feb 24 2023, 1:08 PM · WikiSEO

Feb 7 2023

Aklapper edited projects for T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError, added: Patch-Needs-Improvement; removed Patch-For-Review.
Feb 7 2023, 12:58 AM · Patch-Needs-Improvement, WikiSEO

Jan 11 2023

Samwilson added a watcher for WikiSEO: Samwilson.
Jan 11 2023, 10:16 PM

Dec 15 2022

RhinosF1 removed a member for WikiSEO: RhinosF1.
Dec 15 2022, 9:19 PM

Dec 3 2022

Octfx added a comment to T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.

I think this was fixed a while back. At least when running php extensions/WikiSeo/maintenance/GenerateDescription.php --force 0 on MW 1.39 no such exception occurs.

Dec 3 2022, 3:26 PM · Patch-Needs-Improvement, WikiSEO
Aklapper closed T317921: Add Parser function to prevent "dateModified" and "datePublished" from being added as Resolved.

resolving per last comment

Dec 3 2022, 2:27 PM · affects-Miraheze, WikiSEO
Aklapper renamed T317921: Add Parser function to prevent "dateModified" and "datePublished" from being added from Parser function requested for Extension:WikiSEO to Add Parser function to prevent "dateModified" and "datePublished" from being added.
Dec 3 2022, 2:27 PM · affects-Miraheze, WikiSEO
Octfx added a comment to T320599: Add support for dc.identifier.wikidata meta tag.

Current implementation support:

  • dc.identifier.wikidata
  • author
  • description
  • title
  • site_name
Dec 3 2022, 2:00 PM · WikiSEO
Octfx added a comment to T317439: WikiSEO doesn't show svg logo from $wgLogos.

This is more or less expected, as neither OpenGraph nor Schema.org officially support svg images.

Dec 3 2022, 1:42 PM · WikiSEO
Octfx added a comment to T317921: Add Parser function to prevent "dateModified" and "datePublished" from being added.

Sorry, I've forgot to subscribe to the project! :(

Dec 3 2022, 1:38 PM · affects-Miraheze, WikiSEO
Octfx added a watcher for WikiSEO: Octfx.
Dec 3 2022, 12:52 PM

Oct 19 2022

Stefahn added a comment to T307070: {{#seo:|robots=noindex}} does not create robots tag.

This is great news. Tested it with REL1_35 and it works :) Thanks a lot!

Oct 19 2022, 7:55 AM · WikiSEO

Oct 15 2022

Octfx closed T307070: {{#seo:|robots=noindex}} does not create robots tag as Resolved.

Ah, totally forgot! Thanks @Aklapper

Oct 15 2022, 10:47 AM · WikiSEO
Aklapper added a comment to T307070: {{#seo:|robots=noindex}} does not create robots tag.

@Octfx: Does that mean the task status should be set to resolved or is there more to do?

Oct 15 2022, 10:26 AM · WikiSEO
Octfx added a comment to T307070: {{#seo:|robots=noindex}} does not create robots tag.

This is now implemented in master, REL1_35 and REL1_39 😊

Oct 15 2022, 10:02 AM · WikiSEO

Oct 12 2022

Samwilson created T320599: Add support for dc.identifier.wikidata meta tag.
Oct 12 2022, 8:44 AM · WikiSEO

Oct 5 2022

Stefahn assigned T307070: {{#seo:|robots=noindex}} does not create robots tag to Octfx.
Oct 5 2022, 11:31 AM · WikiSEO

Sep 23 2022

adrelanos added a comment to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.

I don't disagree with this.

Sep 23 2022, 4:51 PM · WikiSEO, PageImages

Sep 18 2022

Prod added a comment to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.

I don't disagree with this.

T301588 seems to address this issue on REL1_38 and newer versions of Extension:PageImages

Then all images wiki wide would need to be added class=notpageimage. That would be a crazy amount of work. I don't think that this is a good solution.

This ticket is a feature request for a global configuration option.

What's your use case for PageImages apart from populating og:image?

Sep 18 2022, 11:28 PM · WikiSEO, PageImages
adrelanos added a comment to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.

T301588 seems to address this issue on REL1_38 and newer versions of Extension:PageImages

Sep 18 2022, 7:27 PM · WikiSEO, PageImages

Sep 15 2022

Axolittle created T317921: Add Parser function to prevent "dateModified" and "datePublished" from being added.
Sep 15 2022, 8:32 PM · affects-Miraheze, WikiSEO

Sep 14 2022

Prod added a comment to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.

T301588 seems to address this issue on REL1_38 and newer versions of Extension:PageImages

Sep 14 2022, 1:14 PM · WikiSEO, PageImages

Sep 9 2022

Peachey88 added a project to T317439: WikiSEO doesn't show svg logo from $wgLogos: WikiSEO.
Sep 9 2022, 8:30 PM · WikiSEO

Jul 20 2022

gerritbot added a comment to T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.

Change 815732 had a related patch set uploaded (by Iijima Yun; author: Iijima Yun):

[mediawiki/extensions/WikiSEO@master] DeferredDescriptionUpdate.php --force: fix type errors related to `array_shift()` call

https://gerrit.wikimedia.org/r/815732

Jul 20 2022, 4:21 PM · Patch-Needs-Improvement, WikiSEO
gerritbot added a project to T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError: Patch-For-Review.
Jul 20 2022, 4:15 PM · Patch-Needs-Improvement, WikiSEO
gerritbot added a comment to T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.

Change 815732 had a related patch set uploaded (by Iijima Yun; author: Iijima Yun):

[mediawiki/extensions/WikiSEO@master] T313419: DeferredDescriptionUpdate.php --force: fix type errors related to `array_shift()` call

https://gerrit.wikimedia.org/r/815732

Jul 20 2022, 4:15 PM · Patch-Needs-Improvement, WikiSEO
IijimaYun added a comment to T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.

I feel like array_shift() is out of place here: even if the assignment is replaced by a simple call, dropping the first element completely, it obviously makes the supposed later test

switch ( true ) {
                        case count( $propertyDescription ) > 1:
                                // There are multiple page props with the name 'description' present
                                // This shouldn't happen, but we'll try to clean it here
                                $db->delete(
                                        'page_props',
                                        [
                                                'pp_page' => $this->title->getArticleID(),
                                                'pp_propname' => 'description',
                                        ]
                                );
                        // Intentional fall-through, as deleting all 'description' props requires inserting a new row
                        case empty( $propertyDescription ):
                                $shouldInsert = true;
                                break;
Jul 20 2022, 3:56 PM · Patch-Needs-Improvement, WikiSEO
IijimaYun renamed T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError from DeferredDescriptionUpdate.php --force: array_shift() converts array into a string leading to a TypeError to DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.
Jul 20 2022, 3:39 PM · Patch-Needs-Improvement, WikiSEO
IijimaYun created T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.
Jul 20 2022, 3:35 PM · Patch-Needs-Improvement, WikiSEO
adrelanos updated the task description for T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.
Jul 20 2022, 7:24 AM · WikiSEO, PageImages

Jul 16 2022

adrelanos added a comment to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO.

Would it help if a patch was provided? Is this something that could potentially get accepted?

Jul 16 2022, 10:31 AM · WikiSEO, PageImages

May 5 2022

Maintenance_bot removed a project from T305534: Create project tag for Extension WikiSEO: Patch-For-Review.
May 5 2022, 7:30 PM · WikiSEO, User-RhinosF1, Project-Admins
gerritbot added a comment to T305534: Create project tag for Extension WikiSEO.

Change 779112 merged by jenkins-bot:

[labs/tools/wikibugs2@master] wikibugs: relay WikiSEO to RhinosF1's channel

https://gerrit.wikimedia.org/r/779112

May 5 2022, 6:57 PM · WikiSEO, User-RhinosF1, Project-Admins

Apr 28 2022

Stefahn created T307070: {{#seo:|robots=noindex}} does not create robots tag.
Apr 28 2022, 7:34 AM · WikiSEO

Apr 12 2022

Maintenance_bot moved T305534: Create project tag for Extension WikiSEO from Radar to Done on the User-RhinosF1 board.
Apr 12 2022, 8:29 PM · WikiSEO, User-RhinosF1, Project-Admins
gerritbot added a project to T305534: Create project tag for Extension WikiSEO: Patch-For-Review.
Apr 12 2022, 8:20 PM · WikiSEO, User-RhinosF1, Project-Admins
gerritbot added a comment to T305534: Create project tag for Extension WikiSEO.

Change 779112 had a related patch set uploaded (by RhinosF1; author: RhinosF1):

[labs/tools/wikibugs2@master] wikibugs: relay WikiSEO to RhinosF1's channel

https://gerrit.wikimedia.org/r/779112

Apr 12 2022, 8:20 PM · WikiSEO, User-RhinosF1, Project-Admins
RhinosF1 added projects to T305534: Create project tag for Extension WikiSEO: User-RhinosF1, WikiSEO.
Apr 12 2022, 8:17 PM · WikiSEO, User-RhinosF1, Project-Admins
RhinosF1 added a project to T300587: PageImages: configuration option omit og:image / compatibility with WikiSEO: WikiSEO.
Apr 12 2022, 8:14 PM · WikiSEO, PageImages
Aklapper added a project to T305519: [WikiSEO] Mark some wiki-seo-param-* messages as raw: User-RhinosF1.
Apr 12 2022, 8:01 PM · User-RhinosF1, WikiSEO
RhinosF1 added a member for WikiSEO: RhinosF1.
Apr 12 2022, 7:10 PM
sbassett added a comment to T295065: Security Readiness Review For WikiSEO.

I hadn't found a way to create img and a elements without using Html::rawElement.
But I think as they don't contain user submitted content they should be safe.

Apr 12 2022, 3:46 PM · WikiSEO, secscrum, Security, Application Security Reviews
Octfx added a member for WikiSEO: Octfx.
Apr 12 2022, 3:07 PM
Aklapper added a project to T295065: Security Readiness Review For WikiSEO: WikiSEO.
Apr 12 2022, 1:31 PM · WikiSEO, secscrum, Security, Application Security Reviews
Aklapper removed a project from T305519: [WikiSEO] Mark some wiki-seo-param-* messages as raw: MediaWiki-extensions-Other.
Apr 12 2022, 1:31 PM · User-RhinosF1, WikiSEO
Aklapper edited projects for T305519: [WikiSEO] Mark some wiki-seo-param-* messages as raw, added: WikiSEO; removed User-RhinosF1.
Apr 12 2022, 1:31 PM · User-RhinosF1, WikiSEO
Aklapper set Source Repo to https://gerrit.wikimedia.org/g/mediawiki/extensions/WikiSEO on WikiSEO.
Apr 12 2022, 1:31 PM
Aklapper created WikiSEO.
Apr 12 2022, 1:30 PM