Allure-mocha: fix test result overwritten when a test is skipped dynamically #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If a test is skipped at runtime (with
this.skip();
), the test result gets overwritten, and all the data (links, labels, etc) is lost.In such cases,
onTest
is called beforeonPending
so there is no need to create a new test result.Also, we might want to implement a countermeasure of some sort (a warning or an error) if we dismiss the currently running test result.
Other changes
Fixes #457
Checklist