fix(compiler-cli): rename flag for enabling fast type declaration emission (#61353)

Jonathan Meier · thePunderWoman · commit 77fa204ad16f · 2025-05-19T08:27:43.000Z
Rename the flag `_geminiAllowEmitDeclarationOnly` to `_experimentalAllowEmitDeclarationOnly` as a follow-up on a comment in PR #61334. PR Close #61353
diff --git a/goldens/public-api/compiler-cli/compiler_options.api.md b/goldens/public-api/compiler-cli/compiler_options.api.md
@@ -7,7 +7,7 @@
 // @public
 export interface BazelAndG3Options {
     annotateForClosureCompiler?: boolean;
-    _geminiAllowEmitDeclarationOnly?: boolean;
+    _experimentalAllowEmitDeclarationOnly?: boolean;
     generateDeepReexports?: boolean;
     generateExtraImportsInLocalMode?: boolean;
     onlyExplicitDeferDependencyImports?: boolean;
diff --git a/packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts b/packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts
@@ -353,9 +353,9 @@ export interface BazelAndG3Options {
    * references.
    *
    * The mode is experimental and specifically tailored to support fast type declaration emission
-   * for the Gemini app in g3.
+   * for the Gemini app in g3 for the initial phase of the experiment.
    */
-  _geminiAllowEmitDeclarationOnly?: boolean;
+  _experimentalAllowEmitDeclarationOnly?: boolean;
 }
 
 /**
diff --git a/packages/compiler-cli/src/ngtsc/core/src/compiler.ts b/packages/compiler-cli/src/ngtsc/core/src/compiler.ts
@@ -468,7 +468,7 @@ export class NgCompiler {
     this.enableLetSyntax = options['_enableLetSyntax'] ?? true;
     this.enableSelectorless = options['_enableSelectorless'] ?? false;
     this.emitDeclarationOnly =
-      !!options.emitDeclarationOnly && !!options._geminiAllowEmitDeclarationOnly;
+      !!options.emitDeclarationOnly && !!options._experimentalAllowEmitDeclarationOnly;
     // Standalone by default is enabled since v19. We need to toggle it here,
     // because the language service extension may be running with the latest
     // version of the compiler against an older version of Angular.
diff --git a/packages/compiler-cli/test/compliance/declaration-only/declaration_only_emit_spec.ts b/packages/compiler-cli/test/compliance/declaration-only/declaration_only_emit_spec.ts
@@ -43,7 +43,7 @@ function emitDeclarationOnlyTest(fs: FileSystem, test: ComplianceTest): CompileR
     },
     {
       ...test.angularCompilerOptions,
-      _geminiAllowEmitDeclarationOnly: true,
+      _experimentalAllowEmitDeclarationOnly: true,
     },
   );
 }
diff --git a/packages/compiler-cli/test/ngtsc/declaration_only_emission_spec.ts b/packages/compiler-cli/test/ngtsc/declaration_only_emission_spec.ts
@@ -31,7 +31,7 @@ runInEachFileSystem(() => {
           noCheck: true,
         },
         angularCompilerOptions: {
-          _geminiAllowEmitDeclarationOnly: true,
+          _experimentalAllowEmitDeclarationOnly: true,
         },
       };
       env.write('tsconfig.json', JSON.stringify(tsconfig, null, 2));

Original file line number	Diff line number	Diff line change
`@@ -353,9 +353,9 @@ export interface BazelAndG3Options {`
`353`	`353`	`* references.`
`354`	`354`	`*`
`355`	`355`	`* The mode is experimental and specifically tailored to support fast type declaration emission`
`356`		`- * for the Gemini app in g3.`
	`356`	`+ * for the Gemini app in g3 for the initial phase of the experiment.`
`357`	`357`	`*/`
`358`		`- _geminiAllowEmitDeclarationOnly?: boolean;`
	`358`	`+ _experimentalAllowEmitDeclarationOnly?: boolean;`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ function emitDeclarationOnlyTest(fs: FileSystem, test: ComplianceTest): CompileR`
`43`	`43`	`},`
`44`	`44`	`{`
`45`	`45`	`...test.angularCompilerOptions,`
`46`		`- _geminiAllowEmitDeclarationOnly: true,`
	`46`	`+ _experimentalAllowEmitDeclarationOnly: true,`
`47`	`47`	`},`
`48`	`48`	`);`
`49`	`49`	`}`