feat: Add upToScope parameter to hasBinding
#17102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liuxingbaoyu
commented
Jan 30, 2025
| Q | A |
|---|---|
| Fixed Issues? | Fixes #17064 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58665 |
JLHwung
approved these changes
Feb 3, 2025
| ) { | ||
| if (!name) return false; | ||
| const upToScope = (opts as { upToScope?: Scope })?.upToScope; |
There was a problem hiding this comment.
nit: Let's move opts normalization here so we don't have to do the typecast.
JLHwung
reviewed
Feb 4, 2025
| if (scope.hasOwnBinding(name)) { | ||
| return true; | ||
| } | ||
| } while ((scope = scope.parent)); | ||
|
|
||
| if (!noUids && this.hasUid(name)) return true; | ||
| if (!noGlobals && Scope.globals.includes(name)) return true; |
There was a problem hiding this comment.
How do you think noGlobals and noUids should interact with the upToScope option? The current behaviour is to completely ignore them when upToScope is configured, as if they were both true.
JLHwung
approved these changes
Feb 6, 2025
nicolo-ribaudo
approved these changes
Feb 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.