fix(lsp): custom configuration path should not override the working directory #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhedger
approved these changes
May 24, 2025
19861d4 to
e28da2c
Compare
ematipico
approved these changes
May 27, 2025
|
@ematipico Custom configuration path from LSP workspaces is added by #5093, which is not released yet. Thus we can skip a changeset, is it correct? |
|
Oh sorry, I forgot that. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During the initialisation process of the workspace from LSP, the root directory of the project is overriden by the specified configuration path. I believe it's not intended when we use any custom configuration file, and replaced the logic to always use the current working directory even if the configuration path is provided.
Test Plan
Manually tested with VS Code.