Skip to content

fix(textarea): placeholder with chinese chars #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix(textarea): placeholder with chinese chars #767

merged 1 commit into from
Mar 31, 2025

Conversation

caarlos0
Copy link
Member

closes #579

@caarlos0 caarlos0 added the bug Something isn't working label Mar 31, 2025
@caarlos0 caarlos0 self-assigned this Mar 31, 2025
@caarlos0 caarlos0 mentioned this pull request Mar 31, 2025
Closed
caarlos0 added a commit that referenced this pull request Mar 31, 2025
@caarlos0
fix(textinput): improve placeholder
1a557ba 
similar to #767 but for textinputs
@caarlos0 caarlos0 mentioned this pull request Mar 31, 2025
Open
bashbunni
bashbunni approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks about right! My deps are all messed up trying to run the bubble tea example with bubbles so I couldn't test this locally, but that test output is 👌

@caarlos0 caarlos0 merged commit 8b55efb into master Mar 31, 2025
16 of 22 checks passed
@caarlos0 caarlos0 deleted the textarea-placeholder branch March 31, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbunni bashbunni bashbunni approved these changes

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas is a code owner

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textarea.Placeholder cannot display the first Chinese character properly
2 participants
@caarlos0 @bashbunni