chore: allow organization name or uuid for audit log searching #13721
Conversation
| @@ -177,13 +177,48 @@ func TestAuditLogs(t *testing.T) { | |||
|
|
|||
| // Using the organization selector allows the org admin to fetch audit logs | |||
| alogs, err := orgAdmin.AuditLogs(ctx, codersdk.AuditLogsRequest{ | |||
| SearchQuery: fmt.Sprintf("organization_id:%s", owner.OrganizationID.String()), | |||
There was a problem hiding this comment.
we should continue testing that searching by organization_id works
EDIT: undocumented feature
| } else { | ||
| // Organization could be a name | ||
| organization, err := db.GetOrganizationByName(ctx, organizationArg) | ||
| if err != nil { |
There was a problem hiding this comment.
ah my bad, I fixated on line 33 but missed this check 👍
There was a problem hiding this comment.
Yea, I use the same query param of organization. Feels more straight forward
There was a problem hiding this comment.
Might be worth adding some sort of error if you use organization_id to suggest using organization.
Note that this param is not documented or used anywhere yet.
There was a problem hiding this comment.
Only problem is this might break existing queries, idk if any folks would have a reason to use this yet?
There was a problem hiding this comment.
Note that this param is not documented or used anywhere yet.
Ah, if it's not documented then all bets are off.
There was a problem hiding this comment.
Yea, I added it 2 days ago, and intentionally am not documenting any of the multi-org stuff yet: #13663
What this does
Allows using organization name in the
organizationfilter for audit log searching.