Skip to content

fix: stop blocking fake Agent API channel writes after context expires #13908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: stop blocking fake Agent API channel writes after context expires #13908

merged 1 commit into from
Jul 16, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jul 16, 2024 •
edited
Loading

fixes #13882

@spikecurtis Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis requested a review from dannykopping July 16, 2024 19:12
@spikecurtis spikecurtis marked this pull request as ready for review July 16, 2024 19:12
@spikecurtis spikecurtis merged commit 70c5c47 into main Jul 16, 2024
32 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/flake-fake-agent-api branch July 16, 2024 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: FakeAgentAPI.UpdateStats goroutines on top of stack
2 participants
@spikecurtis @kylecarbs