fix: allow all users to read system notification templates #14181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
johnstcn
reviewed
Aug 6, 2024
Co-authored-by: Cian Johnston <cian@coder.com>
johnstcn
approved these changes
Aug 6, 2024
BrunoQuaresma
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the only entries in the
notification_templatestable are entries of kindsystem. These templates are used for system-related notifications, and are "owned" by the system.All users need access to list these templates as part of coder/internal#19.
For now, I've removed the RBAC check on
GetNotificationTemplatesByKind. In the near future when we enable operators to create their own user-defined notification templates, we'll implement the RBAC check here.All mutative actions on
notification_templatesentries are still protected by the authorization check.