fix: set network telemetry client version on server #14376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson
commented
Aug 21, 2024
658f6f9 to
ec124ba
Compare
deansheather
approved these changes
Aug 22, 2024
sreya
reviewed
Aug 22, 2024
|
I think it'd be beneficial to have an E2E network telemetry test. We'd just need to mock the telemetry batcher on a coderdtest instance so we can inspect it. |
|
@ethanndickson there's already a |
|
Unfortunately I don't believe we expose anything like |
ec124ba to
64b79cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the
DisconnectionReasonfield, given that it was unused. Requires a corresponding change on the telemetry server.Closes #14375