feat: notify about manual failed builds #14419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderd/database/migrations/000248_notifications_manual_build_failed.up.sql
Outdated
Show resolved
Hide resolved
johnstcn
reviewed
Aug 26, 2024
Comment on lines
+1851
to
+1861
| assert.Equal(t, notifEnq.Sent[0].UserID, templateAdmin.ID) | ||
| assert.Equal(t, notifEnq.Sent[0].TemplateID, notifications.TemplateWorkspaceManualBuildFailed) | ||
| assert.Contains(t, notifEnq.Sent[0].Targets, template.ID) | ||
| assert.Contains(t, notifEnq.Sent[0].Targets, workspace.ID) | ||
| assert.Contains(t, notifEnq.Sent[0].Targets, workspace.OrganizationID) | ||
| assert.Contains(t, notifEnq.Sent[0].Targets, user.ID) | ||
| assert.Equal(t, workspace.Name, notifEnq.Sent[0].Labels["name"]) | ||
| assert.Equal(t, template.Name, notifEnq.Sent[0].Labels["template_name"]) | ||
| assert.Equal(t, version.Name, notifEnq.Sent[0].Labels["template_version_name"]) | ||
| assert.Equal(t, user.Username, notifEnq.Sent[0].Labels["initiator"]) | ||
| assert.Equal(t, user.Username, notifEnq.Sent[0].Labels["workspace_owner_username"]) |
There was a problem hiding this comment.
I feel like these assertions could be passed into the previous table-based test "Workspace build failed"?
There was a problem hiding this comment.
There is a significant difference as here we expect notifications sent only to template admins, we don't care about workspace owners. I tried to squeeze this unit test as much as possible.
coderd/database/migrations/000248_notifications_manual_build_failed.up.sql
Outdated
Show resolved
Hide resolved
dannykopping
approved these changes
Aug 27, 2024
| @@ -1150,15 +1130,43 @@ func (s *server) notifyWorkspaceManualBuildFailed(ctx context.Context, workspace | |||
| "template_version_name": templateVersion.Name, | |||
| "initiator": build.InitiatorByUsername, | |||
| "workspace_owner_username": workspaceOwner.Username, | |||
| "workspace_build_number": strconv.Itoa(int(build.BuildNumber)), | |||
There was a problem hiding this comment.
Including this will mean that deduplication won't be possible, just so you're aware.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: coder/internal#16
This PR modifies ProvisionerdServer to notify template admins about manual workspace build failures.