Skip to content

feat: add expiration warning #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2023
Merged

feat: add expiration warning #7264

merged 6 commits into from
Apr 26, 2023

Conversation

rodrimaia
Copy link
Contributor

Show a warning if your license is expiring soon:
image

@rodrimaia rodrimaia requested review from mtojek and bpmct April 24, 2023 14:57
@rodrimaia rodrimaia self-assigned this Apr 24, 2023
@rodrimaia rodrimaia changed the title Add expiration warning feat: add expiration warning Apr 24, 2023
rodrimaia
rodrimaia commented Apr 24, 2023
View reviewed changes
mtojek
mtojek approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for 👍 from Ben

@mtojek
Copy link
Member

mtojek commented Apr 25, 2023

@rodrimaia It looks like CI reported a problem here:

    coderd_test.go:72: 
        	Error Trace:	/home/runner/work/coder/coder/enterprise/coderd/coderd_test.go:72
        	Error:      	Should be empty, but was [Your license expires in 1 day.]
        	Test:       	TestEntitlements/FullLicense
    stuntest.go:63: STUN server shutdown

@rodrimaia rodrimaia mentioned this pull request Apr 26, 2023
Closed
@rodrimaia rodrimaia merged commit c3fe251 into main Apr 26, 2023
@rodrimaia rodrimaia deleted the add_expiration_warning branch April 26, 2023 19:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma left review comments

@mtojek mtojek mtojek approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@rodrimaia rodrimaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrimaia @mtojek @BrunoQuaresma @bpmct