Skip to content

docs: add types for multiple rule options #19616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Added the types to new options that are added to support TypeScript syntax.

Is there anything you'd like reviewers to focus on?

No

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner April 11, 2025 12:03
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 11, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 11, 2025
Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 065cc55
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67f9302617737f0008cc5758

@snitin315 snitin315 changed the title chore: add types to rule options docs: add types for multiple rule options Apr 11, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 11, 2025
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion types Related to TypeScript types and removed documentation Relates to ESLint's documentation chore This change is not user-facing labels Apr 11, 2025
@snitin315 snitin315 moved this from Needs Triage to Implementing in Triage Apr 11, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 11, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @snitin315 to verify.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Apologies for the delay in re-review.

@snitin315 snitin315 merged commit 5d4af16 into eslint:main Apr 17, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants