feat: add ignoreDirectives option in no-unused-expressions #19645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
|
I had already raised #19644 😅 |
|
Oh shoot, I didn't see that! Mine is a bit more elaborate; would you like to go with my PR? |
|
I think we would want ignoreDirective option to ignore all directive nodes regardless of ecmaversion, that way we can just rely on the astUtils.isDirective only and remove the unwanted code from the rule |
|
Oh ok I removed those code. All tests seem to pass. |
1 task
snitin315
reviewed
Apr 22, 2025
mdjermanovic
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR adds a new
ignoreDirectivesoption to theno-unused-expressionsrule to address compatibility issues with ES3 codebases.Is there anything you'd like reviewers to focus on?