docs: typo #534
Merged
docs: typo #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Sep 9, 2024
antfu
reviewed
Sep 9, 2024
docs/guide/migration.md
Outdated
| // your own rules | ||
| { | ||
| plugins: { | ||
| stylistic: StylisticPlugin | ||
| }, | ||
| rules: { | ||
| 'stylistic/semi': 'error', | ||
| '@stylistic/semi': 'error', |
There was a problem hiding this comment.
No, this is not how it works. The previous example is correct as we provide the plugin named as stylistic
There was a problem hiding this comment.
my bad, removed
I was confused with all the other examples that name the plugins with @ prefix (e.g. @stylistic/js)
don't you think we should rename it to @stylistic here?
{
plugins: {
'@stylistic': StylisticPlugin
},
rules: {
'@stylistic/semi': 'error',
// ...
}
}
There was a problem hiding this comment.
@stylistic was mainly the convention of the legacy config, where in the flat config I don't want users to carry that legacy convention when they don't need to.
Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unnecessary comma cause diff addition not to show + missing @ before
stylistic: