feat(expo)!: drop EXPO_USE_LOCAL_CLI in favor of using expo for the local CLI and expo-cli for the global CLI.
#21388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he local CLI and `expo-cli` for the global CLI.
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
Feb 24, 2023
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
Feb 24, 2023
packages/expo/CHANGELOG.md
Outdated
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### 🛠 Breaking changes | |||
|
|
|||
| - drop `EXPO_USE_LOCAL_CLI` in favor of using `expo` for the local CLI and `expo-cli` for the global CLI. | |||
There was a problem hiding this comment.
Suggested change
| - drop `EXPO_USE_LOCAL_CLI` in favor of using `expo` for the local CLI and `expo-cli` for the global CLI. | |
| - drop `EXPO_USE_LOCAL_CLI` in favor of using `expo` for the local CLI and `expo-cli` for the global CLI. ([#21388](https://github.com/expo/expo/pull/21388) by [@EvanBacon](https://github.com/EvanBacon)) |
ide
requested changes
Feb 24, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
ide
reviewed
Feb 28, 2023
ide
approved these changes
Feb 28, 2023
tsapeta
approved these changes
Feb 28, 2023
ide
approved these changes
Mar 1, 2023
amandeepmittal
approved these changes
Mar 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Speeds up command invocations. Would be ideal to drop the
expo/bin/cli.jsfile too.