Skip to content

Fix double .update() call on mount #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix double .update() call on mount #2852

merged 2 commits into from
Oct 31, 2024

Conversation

mattgperry
Copy link
Collaborator

This PR ensures that the insertion effect responsible for updating props from a motion commit to its VisualElement only runs when the VisualElement is hydrated with an element reference. This cuts an unnecessary .update() call on mount.

@mattgperry mattgperry requested a review from kurtextrem October 31, 2024 09:52
kurtextrem
kurtextrem approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@kurtextrem kurtextrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mergetron mergetron bot merged commit f3468b3 into main Oct 31, 2024
3 checks passed
@mergetron mergetron bot deleted the fix/double-mount-update branch October 31, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kurtextrem kurtextrem kurtextrem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattgperry @kurtextrem