feat: Adds source_column_match and associated tests #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalmerlowe
commented
Jul 2, 2025
chalmerlowe
commented
Jul 2, 2025
chalmerlowe
commented
Jul 2, 2025
tswast
reviewed
Jul 15, 2025
| # return None | ||
|
|
||
| @source_column_match.setter | ||
| def source_column_match(self, value: Optional[SourceColumnMatch]): |
There was a problem hiding this comment.
I would like us to allow str in the setter as well. Can you update this, please?
google/cloud/bigquery/job/load.py
Outdated
| return None | ||
|
|
||
| @source_column_match.setter | ||
| def source_column_match(self, value: Optional[SourceColumnMatch]): |
There was a problem hiding this comment.
Same here. Can we allow str, please?
google/cloud/bigquery/job/load.py
Outdated
| @@ -983,6 +1017,13 @@ def clustering_fields(self): | |||
| """ | |||
| return self.configuration.clustering_fields | |||
|
|
|||
| @property | |||
| def source_column_match(self): | |||
There was a problem hiding this comment.
Missing return type annotation?
| config._properties["load"]["sourceColumnMatch"] = option_enum.value | ||
| self.assertEqual(config.source_column_match, option_enum) | ||
|
|
||
| def test_source_column_match_setter(self): |
There was a problem hiding this comment.
Could we add another test where we use the setter with a str, too?
There was a problem hiding this comment.
Done, both here and in test_external_config.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new configuration options for BigQuery load jobs and external table definitions, aligning with recent updates to the underlying protos.
New options added:
source_column_name_match_option: Controls how source columns are matched to the schema. (Applies to LoadJobConfig, ExternalConfig, LoadJob)Changes include:
LoadJobConfig,LoadJob,ExternalConfig, andCSVOptions.