[EventEngine] Add stronger wording on Endpoint::Read contract #38036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctiller
approved these changes
Oct 30, 2024
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 6, 2024
…8036) tl;dr: If data is received on the underlying endpoint, it must never be discarded. Closes grpc#38036 COPYBARA_INTEGRATE_REVIEW=grpc#38036 from drfloob:endpoint-cb-xor ab763ca PiperOrigin-RevId: 691508829
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…8036) tl;dr: If data is received on the underlying endpoint, it must never be discarded. Closes grpc#38036 COPYBARA_INTEGRATE_REVIEW=grpc#38036 from drfloob:endpoint-cb-xor ab763ca PiperOrigin-RevId: 691508829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: If data is received on the underlying endpoint, it must never be discarded.