Skip to content

Fix $TFunctionBrand for non-string namespaces #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

jtbandes
Copy link
Contributor

@jtbandes jtbandes commented Jul 12, 2023

Follow-up to #1994
Fix type brand validation for more complex TFunction use cases (like TFunction<["a", "b"]>).
Disable validation when CustomTypeOptions["resources"] is not configured.

@coveralls
Copy link

coveralls commented Jul 12, 2023

Coverage Status

coverage: 92.36%. remained the same when pulling 093b667 on foxglove:jacob/tfunction-fix2 into 3a1b499 on i18next:master.

@jtbandes jtbandes changed the title Set $TFunctionBrand to never for non-string namespaces Fix $TFunctionBrand for non-string namespaces Jul 12, 2023
@adrai adrai merged commit cecf54b into i18next:master Jul 12, 2023
@jtbandes jtbandes deleted the jacob/tfunction-fix2 branch July 12, 2023 19:07
@adrai
Copy link
Member

adrai commented Jul 12, 2023

Thank you @jtbandes...
it's included in v23.2.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants