Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for julia install and mtime maintenance #200

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jan 4, 2024

This should fail on master, and will be added to #196 which should pass

The mtime test only runs on 1.7+ because that's when pkgdir is available, and the mtime issue isn't really a problem back then. It's more since stdlibs have started to be removed from the sysimage.

Interestingly on windows the archive mtimes are maintained, which explains why the cache action works well already on windows julia-actions/cache#85 (comment)

@IanButterworth IanButterworth changed the title add test for julia instal and mtime maintenance add test for julia install and mtime maintenance Jan 4, 2024
@IanButterworth IanButterworth marked this pull request as draft January 4, 2024 16:26
@omus
Copy link
Contributor

omus commented Jan 5, 2024

Can this PR be closed? Looks like the tests were added in #196

@IanButterworth
Copy link
Member Author

IanButterworth commented Jan 5, 2024

Yeah merging that closes all the other open PRs

We decided to merge this separately in a failing state

@IanButterworth IanButterworth marked this pull request as ready for review January 5, 2024 17:33
@IanButterworth IanButterworth merged commit a46a85f into master Jan 5, 2024
25 of 43 checks passed
@IanButterworth IanButterworth deleted the ib/mtime_test branch January 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants