Skip to content

community: Add edge properties to the gremlin graph schema #30449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ianmuge
Copy link
Contributor

@ianmuge ianmuge commented Mar 23, 2025

Description: Extend the gremlin graph schema to include the edge properties, grouped by its triples; i.e: inVLabel and outVLabel. This should give more context when crafting queries to run against a gremlin graph db

Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 24, 2025 7:32pm

@dosubot dosubot bot added size:XS and removed size:XS labels Mar 23, 2025
Comment on lines 99 to 102
".fold()).dedup().fold())"
)
.all()
.result()[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any possible circumstances in which the line above for vertex_properties executes fine, but this raises an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there are no cases I can imagine whereby this can throw errors where the previous steps would have passed

@ianmuge ianmuge requested a review from ccurme March 24, 2025 08:22
@ianmuge ianmuge force-pushed the feature/add-edge-properties-to-the-graph-schema branch from ce2110f to 391ba43 Compare March 24, 2025 19:32
@dosubot dosubot bot added the lgtm label Mar 24, 2025
@ccurme ccurme merged commit a8ce639 into langchain-ai:master Mar 24, 2025
19 checks passed
@ianmuge ianmuge deleted the feature/add-edge-properties-to-the-graph-schema branch March 25, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants