[27.x] c8d/inspect: Fix duplicate RepoDigests #48785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, looks like this needs to be adjusted a bit more, because the inspect refactor didn't make it into the 27.x 🙈 |
Multiple images with the same repository name but different tag caused the `RepoDigests` to contain duplicated entries for each of the image. Deduplicate the slice before setting the `RepoDigests` field. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit ba454f5) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: c8d/inspect: Fix duplicate RepoDigests #48777
fixes: c8d: image inspect should not contain duplicate RepoDigests #48747
Multiple images with the same repository name but different tag caused the
RepoDigeststo contain duplicated entries for each of the image.Use a set instead of a slice to store the digested references to avoid the duplicated values.
- How to verify it
TestImageInspectUniqueRepoDigests
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)