libnet/d/bridge: fix compilation on i386 #49526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On i386, Linux doesn't provide direct socket syscall but instead multiplexes them through the socketcall syscall (see `man 2 socketcall`). This commit fixes compilation for i386 by wrapping the offending syscall in a new function that uses the socketcall syscall on i386, and the `setsockopt` syscall on other archs. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
vvoland
approved these changes
Feb 24, 2025
thaJeztah
reviewed
Feb 24, 2025
Comment on lines
-678
to
-679
| options := sctp.InitMsg{NumOstreams: sctp.SCTP_MAX_STREAM} | ||
| if _, _, errno := syscall.Syscall6(syscall.SYS_SETSOCKOPT, |
There was a problem hiding this comment.
Regression point was b3fabed correct? So from that, there's low risk of that getting into any of the release branches
There was a problem hiding this comment.
Yup, only v28.0.0 is affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
On i386, Linux doesn't provide direct socket syscall but instead multiplexes them through the socketcall syscall (see
man 2 socketcall).- How I did it
This commit fixes compilation for i386 by wrapping the offending syscall in a new function that uses the socketcall syscall on i386, and the
setsockoptsyscall on other archs.- How to verify it
GOARCH=386 ./hack/make.sh binary- Human readable description for the release notes