feat(linter): add autofix for react/self-closing-comp (#10512)

x6eull · web-flow · commit 6908bc390c57 · 2025-04-21T23:16:24.000-04:00
Related to #10477
diff --git a/crates/oxc_linter/src/rules/react/self_closing_comp.rs b/crates/oxc_linter/src/rules/react/self_closing_comp.rs
@@ -60,7 +60,7 @@ declare_oxc_lint!(
     SelfClosingComp,
     react,
     style,
-    pending
+    fix
 );
 
 impl Rule for SelfClosingComp {
@@ -121,7 +121,12 @@ impl Rule for SelfClosingComp {
         }
 
         if self.html && is_dom_comp || self.component && !is_dom_comp {
-            ctx.diagnostic(self_closing_comp_diagnostic(jsx_closing_elem.span));
+            ctx.diagnostic_with_fix(self_closing_comp_diagnostic(jsx_closing_elem.span), |fixer| {
+                fixer.replace(
+                    Span::new(jsx_el.opening_element.span.end - 1, jsx_closing_elem.span.end),
+                    " />",
+                )
+            });
         }
     }
 
@@ -284,7 +289,7 @@ fn test() {
         ),
     ];
 
-    let _fix = vec![
+    let fix = vec![
         (
             r#"var contentContainer = <div className="content"></div>;"#,
             r#"var contentContainer = <div className="content" />;"#,
@@ -351,5 +356,7 @@ fn test() {
             Some(serde_json::json!([{ "html": true }])),
         ),
     ];
-    Tester::new(SelfClosingComp::NAME, SelfClosingComp::PLUGIN, pass, fail).test_and_snapshot();
+    Tester::new(SelfClosingComp::NAME, SelfClosingComp::PLUGIN, pass, fail)
+        .expect_fix(fix)
+        .test_and_snapshot();
 }
