Skip to content

test(linter): ensure complex fixes have messages #10280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

test(linter): ensure complex fixes have messages #10280

merged 1 commit into from
Apr 7, 2025

Conversation

camchenry
Copy link
Member

@camchenry camchenry commented Apr 6, 2025 •
edited
Loading

This adds an assertion which ensures that fixes which change more than a single character have a fix message associated with them.

@camchenry camchenry mentioned this pull request Apr 6, 2025
Merged
@camchenry Graphite App
Copy link
Member Author

camchenry commented Apr 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Apr 6, 2025
@camchenry camchenry force-pushed the 04-06-feat_linter_add_messages_for_complex_fixes branch from 772f7e7 to 8338f4c Compare April 7, 2025 00:01
@camchenry camchenry force-pushed the 04-06-test_linter_ensure_complex_fixes_have_messages branch from 9ed7c64 to 8ba5a8b Compare April 7, 2025 00:01
@camchenry camchenry marked this pull request as ready for review April 7, 2025 00:01
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 7, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10280 will create unknown performance changes

Comparing 04-06-test_linter_ensure_complex_fixes_have_messages (72238fc) with main (72238fc)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 7.9 ms N/A
🆕 formatter[react.development.js] N/A 43.6 µs N/A
🆕 formatter[typescript.js] N/A 7.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.3 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 294.1 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 165.7 ms N/A
🆕 minifier[react.development.js] N/A 1.9 ms N/A
🆕 minifier[typescript.js] N/A 292.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@graphite-app graphite-app bot changed the base branch from 04-06-feat_linter_add_messages_for_complex_fixes to graphite-base/10280 April 7, 2025 02:12
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2025
@camchenry Graphite App
Copy link
Member Author

camchenry commented Apr 7, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Apr 6, 10:14 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 6, 10:14 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 6, 10:15 PM EDT: camchenry added this pull request to the Graphite merge queue.
  • Apr 6, 10:30 PM EDT: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/10280 to main April 7, 2025 02:24
@camchenry
test(linter): ensure complex fixes have messages (#10280)
72238fc 
- related to #10038

This adds an assertion which ensures that fixes which change more than a single character have a fix message associated with them.
@graphite-app graphite-app bot force-pushed the 04-06-test_linter_ensure_complex_fixes_have_messages branch from 8ba5a8b to 72238fc Compare April 7, 2025 02:25
@graphite-app graphite-app bot merged commit 72238fc into main Apr 7, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-06-test_linter_ensure_complex_fixes_have_messages branch April 7, 2025 02:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2025
@oxc-bot oxc-bot mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@camchenry