Skip to content

refactor(language_server): make linter independent of Backend #10497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

refactor(language_server): make linter independent of Backend #10497

merged 1 commit into from
Apr 24, 2025

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Apr 18, 2025 •
edited
Loading

This PR will refactor the language server, so the Linter is independent of the language server.
The changes are needed to support multiple workspaces in the upstream PR.
There, every linter will get its own root Uri, and will report back to the Backend.

The Backend collects the different outputs from the workers and return them to the client when needed.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Apr 18, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Apr 18, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Apr 18, 2025
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 18, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10497 will not alter performance

Comparing 04-18-feat_language_server_support_multiple_workspaces (f6c6969) with main (d1f5abb)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix changed the base branch from 04-17-refactor_language_server_move_code_actions_into_own_file to graphite-base/10497 April 19, 2025 13:23
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from 73faf0d to 1a46000 Compare April 19, 2025 13:24
@Sysix Sysix changed the base branch from graphite-base/10497 to 04-19-refactor_language_server_do_not_request_for_worspace_configuration_when_the_client_does_not_support_it April 19, 2025 13:24
@Sysix Sysix mentioned this pull request Apr 19, 2025
Merged
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch 9 times, most recently from 6123ff4 to a3d554d Compare April 20, 2025 16:57
@Sysix Sysix changed the title feat(language_server): support multiple workspaces refactor(language_server): make linter independent of Backend Apr 20, 2025
@Sysix Sysix removed the C-enhancement Category - New feature or request label Apr 20, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 20, 2025
@Sysix Sysix force-pushed the 04-19-refactor_language_server_do_not_request_for_worspace_configuration_when_the_client_does_not_support_it branch from ebafe04 to 246d6dc Compare April 20, 2025 17:02
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from a3d554d to ef3d0b1 Compare April 20, 2025 17:02
@Sysix Sysix mentioned this pull request Apr 20, 2025
Closed
@graphite-app graphite-app bot changed the base branch from 04-19-refactor_language_server_do_not_request_for_worspace_configuration_when_the_client_does_not_support_it to graphite-base/10497 April 21, 2025 18:12
@Sysix Sysix force-pushed the graphite-base/10497 branch from 246d6dc to db05a15 Compare April 21, 2025 19:38
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from ef3d0b1 to 94f0d9d Compare April 21, 2025 19:38
@Sysix Sysix changed the base branch from graphite-base/10497 to main April 21, 2025 19:38
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from 94f0d9d to 224d614 Compare April 22, 2025 17:19
Sysix
Sysix commented Apr 22, 2025
View reviewed changes
@Sysix Sysix marked this pull request as ready for review April 22, 2025 17:22
@Sysix Sysix requested review from camchenry and Boshen April 22, 2025 17:27
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch 2 times, most recently from 327d41f to 31b5867 Compare April 23, 2025 17:04
@Sysix Sysix mentioned this pull request Apr 23, 2025
Merged
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from 31b5867 to 5e67e03 Compare April 23, 2025 19:16
camchenry
camchenry approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get a better handle on the language server protocol, but I think this makes sense

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Apr 24, 2025 •
edited
Loading

Merge activity

@Sysix
refactor(language_server): make linter independent of Backend (#10497)
f6c6969 
This PR will refactor the language server, so the Linter is independent of the language server.
The changes are needed to support multiple workspaces in the upstream PR.
There, every linter will get its own root Uri, and will report back to the `Backend`.

The `Backend` collects the different outputs from the workers and return them to the client when needed.
@graphite-app graphite-app bot force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from 5e67e03 to f6c6969 Compare April 24, 2025 03:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
@graphite-app graphite-app bot merged commit f6c6969 into main Apr 24, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-18-feat_language_server_support_multiple_workspaces branch April 24, 2025 03:32
@oxc-bot oxc-bot mentioned this pull request Apr 27, 2025
Merged
@Sysix Sysix mentioned this pull request Apr 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camchenry camchenry camchenry approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sysix @camchenry