Skip to content

refactor(linter): improve ast_util::is_method_call #9874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

refactor(linter): improve ast_util::is_method_call #9874

merged 1 commit into from
Mar 18, 2025

Conversation

shulaoda
Copy link
Member

Simplify the method code.

@shulaoda shulaoda requested a review from camc314 March 18, 2025 15:22
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 18, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 18, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9874 will not alter performance

Comparing 03-18-refactor/improve-ast-util-is-method-call (8bdac56) with main (1774225)

Summary

✅ 33 untouched benchmarks

@shulaoda shulaoda added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Mar 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 18, 11:48 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 11:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 11:54 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 03-18-refactor/improve-ast-util-is-method-call branch from 59703c3 to 8bdac56 Compare March 18, 2025 15:48
@graphite-app graphite-app bot merged commit 8bdac56 into main Mar 18, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@graphite-app graphite-app bot deleted the 03-18-refactor/improve-ast-util-is-method-call branch March 18, 2025 15:54
@oxc-bot oxc-bot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @camc314