Skip to content

Don't fail stress tests on Alert #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

Don't fail stress tests on Alert #5961

merged 3 commits into from
Apr 23, 2025

Conversation

hectahertz
Copy link
Contributor

@hectahertz hectahertz commented Apr 23, 2025 •
edited by francinelucca
Loading

Stress tests have been flaky as there's not much historic data.

This makes it so it only leaves a comment and doesn't fail the job.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

CI only

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 16:54
@hectahertz hectahertz requested a review from a team as a code owner April 23, 2025 16:54
@hectahertz hectahertz requested a review from jonrohan April 23, 2025 16:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 171f9f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hectahertz hectahertz added the skip changeset This change does not need a changelog label Apr 23, 2025
Copilot
Copilot AI reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is intended to prevent stress tests from failing when an alert occurs by modifying the alert threshold and fail behavior.

  • Update alert threshold from '150%' to '200%'
  • Adjust the workflow behavior by setting fail-on-alert to false

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.28 KB (0%)
packages/react/dist/browser.umd.js 102.6 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5961 April 23, 2025 17:16 Inactive
francinelucca and others added 2 commits April 23, 2025 13:42
@github-actions github-actions bot requested a deployment to storybook-preview-5961 April 23, 2025 17:46 Abandoned
@hectahertz hectahertz added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 29ffc7f Apr 23, 2025
48 checks passed
@hectahertz hectahertz deleted the hectahertz/stress-tests-flaky branch April 23, 2025 18:19
hectahertz added a commit that referenced this pull request May 20, 2025
@hectahertz @francinelucca @Copilot
Don't fail stress tests on Alert (#5961)
9b56aff 
Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jonrohan jonrohan jonrohan approved these changes

@francinelucca francinelucca francinelucca approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectahertz @jonrohan @francinelucca