Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python/importlib_resources
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.5.0
Choose a base ref
...
head repository: python/importlib_resources
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.5.1
Choose a head ref
  • 8 commits
  • 6 files changed
  • 2 contributors

Commits on Jan 3, 2025

  1. Demonstrate python/cpython#127012 

    This adds an in-memory finder, loader, and traversable implementation,
which allows the `Traversable` protocol and concrete methods to be tested.

This additional infrastructure demonstrates python/cpython#127012,
but also highlights that the `Traversable.joinpath()` concrete method
raises `TraversalError` which is not getting caught in several places.
    @kurtmckee @jaraco
    kurtmckee authored and jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    912a9e5 View commit details
    Browse the repository at this point in the history

  2. Catch TraversalError, raised by Traversable.joinpath() 

    Exercising the `Traversable` protocol's concrete methods
has highlighted that `.joinpath()` raises `TraversalError`,
which needs to be caught in several places.

This is primarily resolved within the test suite,
but implicates the `is_resource()` function as well.
    @kurtmckee @jaraco
    kurtmckee authored and jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    f10a2e9 View commit details
    Browse the repository at this point in the history

  3. Resolve a TypeError lurking in the read_text() functional API 

    `importlib_resources.read_text()` calls the `Traversable.read_text()`
concrete method with an `errors` argument that doesn't exist in the
method signature, resulting in an `TypeError`.

This is resolved by adding an `errors` parameter to
`Traversable.read_text()`.

Fixes python/cpython#127012
    @kurtmckee @jaraco
    kurtmckee authored and jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    d001110 View commit details
    Browse the repository at this point in the history

  4. Consolidate MemoryTraversable._resolve.

    @jaraco
    jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    72d550d View commit details
    Browse the repository at this point in the history

  5. Replace unreachable block with simple assertion. Fixes diffcov failure.

    @jaraco
    jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    cf269ce View commit details
    Browse the repository at this point in the history

  6. Add news fragment.

    @jaraco
    jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    9a872e5 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #321 from kurtmckee/add-readtext-errors-parameter-… 

    …cpython-issue-127012

Add a `Traversable.read_text()` `errors` parameter
    @jaraco
    jaraco authored Jan 3, 2025
    Configuration menu
    Copy the full SHA
    10d87bf View commit details
    Browse the repository at this point in the history

  8. Finalize

    @jaraco
    jaraco committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    78c4bda View commit details
    Browse the repository at this point in the history
Loading