Skip to content

Fix test_python_get_preferred_default with Python pre-releases #10303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix test_python_get_preferred_default with Python pre-releases #10303

merged 1 commit into from
Mar 27, 2025

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Mar 26, 2025 •
edited by sourcery-ai bot
Loading

The version we check is now Version.parse("3.14.0.alpha.6") instead of Version.parse("3.14.0").

Fixes #10302

Summary by Sourcery

Update test case to correctly handle Python pre-release versions by adjusting version parsing

Bug Fixes:

  • Fix version parsing for Python pre-release versions to correctly capture the full version string

Tests:

  • Modify test_python_get_preferred_default to dynamically adjust version length based on whether the Python version is a final release

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Mar 26, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

The pull request modifies the test_python_get_preferred_default test case to accurately parse and compare Python versions, including pre-release versions like alpha, beta, or release candidate builds. This ensures the test case remains valid and reliable when run against pre-release Python versions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Adjusted the version parsing logic in test_python_get_preferred_default to correctly handle Python pre-release versions.
  • Introduced a conditional check to determine the length of the version tuple based on whether the Python version is a final release or a pre-release.
  • Modified the version parsing to include the pre-release identifier when present.
 tests/utils/test_python_manager.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 26, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hroncok - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using packaging.version.Version to compare versions instead of string manipulation.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hroncok @radoering
Fix test_python_get_preferred_default with Python pre-releases
6cebd14 
The version we check is now Version.parse("3.14.0.alpha.6") instead of Version.parse("3.14.0").

Fixes python-poetry#10302
@radoering radoering force-pushed the test_python_get_preferred_default branch from f50da26 to 6cebd14 Compare March 27, 2025 16:23
@radoering radoering enabled auto-merge (squash) March 27, 2025 16:23
@radoering radoering merged commit bca92d5 into python-poetry:main Mar 27, 2025
53 checks passed
@hroncok hroncok deleted the test_python_get_preferred_default branch March 27, 2025 16:42
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_python_get_preferred_default doesn't work on pre-releases
2 participants
@hroncok @radoering