Skip to content

feat(react-router): support invalid Date in turbo-stream v2 fork #13684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2025
Merged

feat(react-router): support invalid Date in turbo-stream v2 fork #13684

merged 7 commits into from
Jun 25, 2025
+50 −1

Conversation

rururux
Copy link
Contributor

@rururux rururux commented May 26, 2025

fixes #13308

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 26, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4697307

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title support encoding and decoding of invalid Date in turbo-stream feat(react-router): support invalid Date in turbo-stream v2 fork May 26, 2025
@rururux
Copy link
Contributor Author

rururux commented Jun 25, 2025

Hi @markdalgleish, @brophdawg11, @jacob-ebey

Just following up on my PR from about a month ago.
Please let me know if there's anything I can do to help move it forward!

Thanks in advance!

brophdawg11
brophdawg11 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just want a double check from @jacob-ebey

@brophdawg11
Copy link
Contributor

Actually - can you add a changeset? Need one before we can merge to capture this in the release notes.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 25, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@rururux
Copy link
Contributor Author

rururux commented Jun 25, 2025

OK, changeset added!

MichaelDeBoey
MichaelDeBoey requested changes Jun 25, 2025
View reviewed changes
@rururux
Copy link
Contributor Author

rururux commented Jun 25, 2025

oops, sorry and thank you🙏

@brophdawg11 brophdawg11 merged commit 9f1e48d into remix-run:dev Jun 25, 2025
8 checks passed
@brophdawg11 brophdawg11 mentioned this pull request Jun 25, 2025
Closed
@rururux
Copy link
Contributor Author

rururux commented Jun 25, 2025

Thanks so much for merging! Really appreciate it.

@rururux rururux deleted the invalid-date-in-turbo-stream branch June 25, 2025 21:42
@github-actions github-actions bot mentioned this pull request Jul 11, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdorr timdorr timdorr approved these changes

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@jacob-ebey jacob-ebey jacob-ebey approved these changes

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

Assignees
No one assigned
Labels
CLA Signed feat:router feat:streaming pkg:react-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rururux @brophdawg11 @timdorr @MichaelDeBoey @jacob-ebey