Skip to content

fix(debug): prevent multiple writes on the same file #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

fix(debug): prevent multiple writes on the same file #4117

merged 1 commit into from
Apr 15, 2025

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Apr 15, 2025 •
edited
Loading

Description

Has comfirmed with vite-devtool team. This PR fix their problems.

@hyf0 hyf0 marked this pull request as ready for review April 15, 2025 10:14
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Apr 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 2f95b56
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67fe318961992d00084b0c49

@github-actions GitHub Actions
Copy link
Contributor

Benchmarks Rust

  • target: main(149a7b9)
  • pr: 04-15-fix_debug_prevent_multiple_writes_on_the_same_file(2f95b56)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     73.9±1.34ms        ? ?/sec    1.00     73.7±1.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     95.0±1.14ms        ? ?/sec    1.01     95.8±1.19ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    108.1±1.29ms        ? ?/sec    1.01    108.8±1.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     83.8±1.45ms        ? ?/sec    1.00     84.0±2.97ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    123.4±1.43ms        ? ?/sec    1.00    123.6±1.96ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    200.0±2.36ms        ? ?/sec    1.01    201.6±4.11ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    242.7±3.16ms        ? ?/sec    1.00    241.7±3.80ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    135.9±1.61ms        ? ?/sec    1.01    136.8±2.04ms        ? ?/sec
bundle/bundle@threejs                                               1.00     41.6±0.40ms        ? ?/sec    1.00     41.7±0.56ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     85.1±0.41ms        ? ?/sec    1.01     86.0±0.82ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    100.2±1.48ms        ? ?/sec    1.06    106.6±0.71ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     48.5±0.85ms        ? ?/sec    1.00     48.2±0.47ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00   430.8±12.39ms        ? ?/sec    1.02    438.9±6.77ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1081.1±16.85ms        ? ?/sec    1.00   1079.6±9.62ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1271.4±12.14ms        ? ?/sec    1.00  1262.6±10.11ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    506.0±4.06ms        ? ?/sec    1.00    507.3±3.85ms        ? ?/sec
remapping/remapping                                                 1.04     26.9±0.98ms        ? ?/sec    1.00     25.7±0.73ms        ? ?/sec
remapping/render-chunk-remapping                                    1.09     71.7±5.50ms        ? ?/sec    1.00     65.6±3.17ms        ? ?/sec
scan/scan@rome-ts                                                   1.06     99.6±1.70ms        ? ?/sec    1.00     94.2±1.30ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.4±0.43ms        ? ?/sec    1.01     31.6±1.80ms        ? ?/sec
scan/scan@threejs10x                                                1.02    323.0±6.63ms        ? ?/sec    1.00    318.0±3.24ms        ? ?/sec

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 15, 2025

Open in StackBlitz

rolldown

npm i https://pkg.pr.new/rolldown@4117

@rolldown/wasi

npm i https://pkg.pr.new/@rolldown/wasi@4117

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@4117

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@4117

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@4117

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@4117

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@4117

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@4117

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@4117

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@4117

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@4117

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@4117

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@4117

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@4117

commit: 2f95b56

@hyf0 hyf0 requested a review from IWANABETHATGUY April 15, 2025 11:23
IWANABETHATGUY
IWANABETHATGUY reviewed Apr 15, 2025
View reviewed changes
@hyf0 hyf0 added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 15, 2025
@hyf0 hyf0 added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 15, 2025
@hyf0 hyf0 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 9131bdc Apr 15, 2025
54 of 69 checks passed
@hyf0 hyf0 deleted the 04-15-fix_debug_prevent_multiple_writes_on_the_same_file branch April 15, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees
No one assigned
Labels
needs-triage trigger: preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyf0 @IWANABETHATGUY