Skip to content

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Aug 5, 2024

Proposed changes

Add the --gitignore option to LINTER_COMMANDS_ARRAY_JSCPD when
IGNORE_GITIGNORED_FILES=true. Users can also set the gitignore options
in the Jscpd configuration file, but with this change we make Jscpd
automatically respecting that.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Aug 5, 2024
@ferrarimarco ferrarimarco added this to the 6.9.0 milestone Aug 5, 2024
@ferrarimarco ferrarimarco self-assigned this Aug 5, 2024
@ferrarimarco ferrarimarco changed the title feat: support ignore_gitignore_files with jscp feat: support ignore_gitignored_files with jscp Aug 5, 2024
@ferrarimarco ferrarimarco changed the title feat: support ignore_gitignored_files with jscp feat: support ignore_gitignored_files with jscpd Aug 5, 2024
Add the --gitignore option to LINTER_COMMANDS_ARRAY_JSCPD when
IGNORE_GITIGNORED_FILES=true. Users can also set the gitignore options
in the Jscpd configuration file, but with this change we make Jscpd
automatically respecting that.
@ferrarimarco ferrarimarco force-pushed the feat-jscpd-gitignore branch from 729069b to bd2765d Compare August 5, 2024 08:02
@ferrarimarco ferrarimarco merged commit 0dbe144 into main Aug 5, 2024
130 checks passed
@ferrarimarco ferrarimarco deleted the feat-jscpd-gitignore branch August 5, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant