Skip to content

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jun 29, 2025

Expressions like delete 1 and delete [] should not trigger errors in a JavaScript/TypeScript parser, as these represent semantic errors rather than syntax errors.

@bvanjoi bvanjoi requested a review from a team as a code owner June 29, 2025 10:01
Copy link

changeset-bot bot commented Jun 29, 2025

🦋 Changeset detected

Latest commit: 16653a6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bvanjoi bvanjoi changed the title fix(es/parser): allow prop operand in delete fix(es/parser): allow non-prop operand in delete Jun 29, 2025
Copy link

codspeed-hq bot commented Jun 29, 2025

CodSpeed Performance Report

Merging #10733 will not alter performance

Comparing bvanjoi:main (16653a6) with main (04ef20a)

Summary

✅ 141 untouched benchmarks

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write some description?

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Jun 29, 2025

Can you write some description?

Done.

@kdy1 kdy1 added this to the Planned milestone Jun 30, 2025
kdy1
kdy1 previously approved these changes Jun 30, 2025
@kdy1 kdy1 changed the title fix(es/parser): allow non-prop operand in delete fix(es/parser): Allow non-prop operand in delete Jun 30, 2025
@kdy1 kdy1 requested a review from a team as a code owner June 30, 2025 04:06
@kdy1 kdy1 merged commit 38132e0 into swc-project:main Jun 30, 2025
18 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.12.8 Jul 1, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants