Skip to content

grep remove testutil #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2023
Merged

grep remove testutil #2649

merged 3 commits into from
Apr 11, 2023

Conversation

binjip978
Copy link
Contributor

No description provided.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Apr 8, 2023
rminnich
rminnich approved these changes Apr 10, 2023
View reviewed changes
@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Apr 10, 2023
rminnich
rminnich previously approved these changes Apr 11, 2023
View reviewed changes
@binjip978
cmds/core/grep: remove testutil and globals
3e33728 
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978
cmds/core/grep: add files test
bc36adf 
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978
cmds/core/grep: embed params into struct
73f49bb 
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978 binjip978 requested a review from rminnich April 11, 2023 10:09
@binjip978 binjip978 added automerge Applying this label auto-merges the PR when ready Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Apr 11, 2023
@rminnich rminnich merged commit bb3e43c into u-root:main Apr 11, 2023
@binjip978 binjip978 deleted the grep-testutil branch April 11, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rminnich rminnich rminnich approved these changes

Assignees
No one assigned
Labels
automerge Applying this label auto-merges the PR when ready Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binjip978 @rminnich