Skip to content

cmds/core/wc: fix bug with early quit if file is not exists #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

binjip978
Copy link
Contributor

remove globals flags from run function
rewrite test with tempDir
seperate stdin tests from file tests

remove globals flags from run function
rewrite test with tempDir
seperate stdin tests from file tests

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Apr 14, 2023
rminnich
rminnich previously approved these changes Apr 14, 2023
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will allow us to use wc in forkless environments!

@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Apr 14, 2023
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978 binjip978 requested a review from rminnich April 14, 2023 15:39
@binjip978 binjip978 added automerge Applying this label auto-merges the PR when ready Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Apr 14, 2023
@rminnich rminnich merged commit d193758 into u-root:main Apr 15, 2023
@binjip978 binjip978 deleted the wc-m branch April 15, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Applying this label auto-merges the PR when ready Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants