]> BookStack Code Mirror - bookstack/commit
Removed setting override system due to confusing behaviour
authorDan Brown <redacted>
Sun, 22 Dec 2019 13:17:14 +0000 (13:17 +0000)
committerDan Brown <redacted>
Sun, 22 Dec 2019 13:19:17 +0000 (13:19 +0000)
commite06f9f7fe3af9a0218b6530c4ebe3fef1c7925f6
tree633ccbffec2825ce6920bfc6fd2b3d6b6f58419b
parent32e7f0a2e672226384f58a0f7ba96e0b17535d4a
Removed setting override system due to confusing behaviour

- Was only used to disable registration when LDAP was enabled.
- Caused saved option not to show on settings page causing confusion.
- Extended setting logic where used to take ldap into account instead of
global override.
- Added warning on setting page to show registration enable setting is
not used while ldap is active.

For #1541
app/Auth/Access/SocialAuthService.php
app/Http/Controllers/Auth/RegisterController.php
app/Settings/SettingService.php
resources/lang/en/settings.php
resources/views/auth/login.blade.php
resources/views/common/header.blade.php
resources/views/settings/index.blade.php
tests/Auth/Saml2Test.php [moved from tests/Auth/Saml2.php with 99% similarity]
tests/Uploads/UsesImages.php