From: Dan Brown Date: Thu, 7 Aug 2025 15:37:18 +0000 (+0100) Subject: A11y: Updated other dropdown menus with correct tagging X-Git-Tag: v25.07.1~1^2~7^2^2 X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/refs/pull/5753/head A11y: Updated other dropdown menus with correct tagging Made some form improvements at the same time. --- diff --git a/lang/en/entities.php b/lang/en/entities.php index ef625a3d2..74c50be3b 100644 --- a/lang/en/entities.php +++ b/lang/en/entities.php @@ -63,6 +63,10 @@ return [ 'import_delete_desc' => 'This will delete the uploaded import ZIP file, and cannot be undone.', 'import_errors' => 'Import Errors', 'import_errors_desc' => 'The follow errors occurred during the import attempt:', + 'breadcrumb_siblings_for_page' => 'Navigate siblings for page', + 'breadcrumb_siblings_for_chapter' => 'Navigate siblings for chapter', + 'breadcrumb_siblings_for_book' => 'Navigate siblings for book', + 'breadcrumb_siblings_for_bookshelf' => 'Navigate siblings for shelf', // Permissions and restrictions 'permissions' => 'Permissions', diff --git a/resources/sass/_components.scss b/resources/sass/_components.scss index 9e96b39fb..8ea15de80 100644 --- a/resources/sass/_components.scss +++ b/resources/sass/_components.scss @@ -904,8 +904,11 @@ body.flexbox-support #entity-selector-wrap .popup-body .form-group { border-radius: 4px; line-height: normal; padding: vars.$xs; + opacity: 0.6; + cursor: pointer; &:hover { - border-color: #DDD; + opacity: 1; + @include mixins.lightDark(border-color, #DDD, #444); } .svg-icon { margin-inline-end: 0; diff --git a/resources/sass/styles.scss b/resources/sass/styles.scss index c6642d0ca..4bae5da66 100644 --- a/resources/sass/styles.scss +++ b/resources/sass/styles.scss @@ -232,13 +232,15 @@ $loadingSize: 10px; .list-sort-label { font-weight: bold; display: inline-block; + } + .list-sort-label, .list-sort-toggle { @include mixins.lightDark(color, #555, #888); } .list-sort-type { text-align: start; } - .list-sort-type, .list-sort-dir { - padding: vars.$xs vars.$s; + .list-sort-toggle, .list-sort-dir { + padding: (vars.$xs + 2) vars.$s; cursor: pointer; } .list-sort-dir { @@ -252,6 +254,11 @@ $loadingSize: 10px; transform: rotate(180deg); } } + .list-sort-toggle { + display: block; + width: 100%; + text-align: start; + } } .import-item { diff --git a/resources/views/common/sort.blade.php b/resources/views/common/sort.blade.php index e5336d3a2..d47351cb3 100644 --- a/resources/views/common/sort.blade.php +++ b/resources/views/common/sort.blade.php @@ -29,10 +29,14 @@
- -
diff --git a/resources/views/entities/breadcrumb-listing.blade.php b/resources/views/entities/breadcrumb-listing.blade.php index 4f751a93f..180e2d211 100644 --- a/resources/views/entities/breadcrumb-listing.blade.php +++ b/resources/views/entities/breadcrumb-listing.blade.php @@ -2,11 +2,14 @@ option:dropdown-search:url="/search/entity/siblings?entity_type={{$entity->getType()}}&entity_id={{ $entity->id }}" option:dropdown-search:local-search-selector=".entity-list-item" class="dropdown-search"> - - \ No newline at end of file diff --git a/resources/views/entities/export-menu.blade.php b/resources/views/entities/export-menu.blade.php index e58c842ba..7b5f889ca 100644 --- a/resources/views/entities/export-menu.blade.php +++ b/resources/views/entities/export-menu.blade.php @@ -2,23 +2,22 @@ class="dropdown-container" id="export-menu"> - +
diff --git a/resources/views/entities/list-item-basic.blade.php b/resources/views/entities/list-item-basic.blade.php index 398c33b93..4c66eec3d 100644 --- a/resources/views/entities/list-item-basic.blade.php +++ b/resources/views/entities/list-item-basic.blade.php @@ -1,5 +1,8 @@ getType(); ?> - + @icon($type)

{{ $entity->preview_name ?? $entity->name }}

diff --git a/resources/views/entities/watch-controls.blade.php b/resources/views/entities/watch-controls.blade.php index 4a119c272..81e80ed98 100644 --- a/resources/views/entities/watch-controls.blade.php +++ b/resources/views/entities/watch-controls.blade.php @@ -1,6 +1,11 @@
- + @@ -10,10 +15,10 @@ -
    +
-
  • +
    • @endforeach
  • {{ trans('entities.watch_change_default') }}
    • diff --git a/resources/views/pages/parts/code-editor.blade.php b/resources/views/pages/parts/code-editor.blade.php index fc8852a32..303b3b0be 100644 --- a/resources/views/pages/parts/code-editor.blade.php +++ b/resources/views/pages/parts/code-editor.blade.php @@ -13,7 +13,7 @@
    - +
    @@ -34,8 +34,8 @@ @foreach($languages as $language)
    - - + +
    @endforeach
    diff --git a/resources/views/pages/parts/editor-toolbar.blade.php b/resources/views/pages/parts/editor-toolbar.blade.php index 2dfbe9e69..ceb5dd64a 100644 --- a/resources/views/pages/parts/editor-toolbar.blade.php +++ b/resources/views/pages/parts/editor-toolbar.blade.php @@ -14,7 +14,7 @@