Refactor parsing object members #9607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some changes around destructuring, restspread and objects.
parseObj()
-loop intoparseObjectMember
.RestElement
inparseObjectMember
not withparseSpread() + toAssignable()
as that seems an overkill if we can parse it directly.RestElement
inparseObjectMember
not withparseRest()
as only Identifier is allowed in this context__proto__
. The spec specifically says only duplicates which come from the form*PropertyDefinition: PropertyName : AssignmentExpression*
: https://www.ecma-international.org/ecma-262/9.0/index.html#sec-__proto__-property-names-in-object-initializers"Rest element must be last element"
This makes the code a little bit simplerparseRest()
toparseRestBinding()