-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Closed
Labels
process: flaky testRelated to test(s) that have flake in our internal testsRelated to test(s) that have flake in our internal tests
Description
system-tests-firefox
seems to fail frequently on snapshot matches when it takes longer than normal to launch Firefox:
Two ways to fix it:
- Support some env var like
CYPRESS_CDP_CONNECTION_TIMEOUT
inprotocol.ts
and pass it insystem-tests.ts
- Filter out the noisy stdout in
system-tests.ts
like we do for video snapshot errors in FF:cypress/system-tests/lib/system-tests.ts
Lines 954 to 968 in 65458d6
try { if (options.originalTitle) { systemTests.snapshot(options.originalTitle, str, { allowSharedSnapshot: true }) } else { systemTests.snapshot(str) } } catch (err) { // firefox has issues with recording video. for now, ignore snapshot diffs that only differ in this error. // @see https://github.com/cypress-io/cypress/pull/16731 if (!(options.browser === 'firefox' && isVideoSnapshotError(err))) { throw err } console.log('(system tests warning) Firefox failed to process the video, but this is being ignored due to known issues with video processing in Firefox.') }
emilyrohrbough
Metadata
Metadata
Assignees
Labels
process: flaky testRelated to test(s) that have flake in our internal testsRelated to test(s) that have flake in our internal tests