Skip to content

fix(js): remove check for non-buildable libs being used when packaging. #11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 1, 2022

  • unblocks custom server in next.js
  • builds are guaranteed to happen if nx.json is configured correctly
  • if a package isn't buildable it will be included in the package in the
    near-future

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #11675

@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Sep 1, 2022

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 1, 2022 at 8:14PM (UTC)

- unblocks custom server in next.js
- builds are guaranteed to happen if nx.json is configured correctly
- if a package isn't buildable it will be included in the package in the
  near-future
@jaysoo jaysoo marked this pull request as ready for review September 1, 2022 20:25
@jaysoo jaysoo merged commit cd3352a into nrwl:master Sep 1, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant