Skip to content

feat(angular): add types to the generated tailwind configuration #12018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

ashley-hunter
Copy link
Contributor

Adding JSDoc to Angular Tailwind configuration to improve editor autocompletion. This now matches the React setup.

Current Behavior

Generates a config with no JSDoc.

Expected Behavior

Should have JSDoc to match React setup

Related Issue(s)

Fixes #

Adding JSDoc to Angular Tailwind configuration to improve editor autocompletion
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Sep 14, 2022

@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 14, 2022 at 9:40PM (UTC)

Adding JSDoc to Angular Tailwind configuration to improve editor autocompletion
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

LGTM! 🎉

@leosvelperez leosvelperez changed the title cleanup(angular): improve tailwind config types feat(angular): add types to the generated tailwind configuration Sep 15, 2022
@leosvelperez leosvelperez merged commit 730d323 into nrwl:master Sep 15, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
@ashley-hunter ashley-hunter deleted the tailwind-types branch March 17, 2023 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants