Skip to content

fix(vite): Failing to build when generated library uses jest #13797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

ndcunningham
Copy link
Contributor

After a react-standalone project is built.
Generating a library with --unit-test-runner=jest would fail

Fixes: #13674

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@ndcunningham ndcunningham requested a review from jaysoo December 13, 2022 14:54
@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 15, 2022 at 3:46PM (UTC)

@ndcunningham ndcunningham force-pushed the fix/vite-config-includevitest branch from c5c14c7 to 8613efc Compare December 13, 2022 14:57
@vercel
Copy link

vercel bot commented Dec 13, 2022

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@ndcunningham ndcunningham force-pushed the fix/vite-config-includevitest branch 3 times, most recently from bf850bb to 43a810d Compare December 13, 2022 15:35
@ndcunningham ndcunningham force-pushed the fix/vite-config-includevitest branch 2 times, most recently from 1c5e4ae to cbcfb21 Compare December 14, 2022 20:42
@ndcunningham ndcunningham force-pushed the fix/vite-config-includevitest branch from cbcfb21 to 6ee03a7 Compare December 15, 2022 14:18
After a react-standalone project is built.
Generating a library with --unit-test-runner=jest would fail

Fixes: nrwl#13674
@jaysoo jaysoo force-pushed the fix/vite-config-includevitest branch from 6ee03a7 to e1b55d8 Compare December 15, 2022 15:45
@jaysoo jaysoo merged commit 70e1aab into nrwl:master Dec 15, 2022
@ndcunningham ndcunningham deleted the fix/vite-config-includevitest branch December 15, 2022 16:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx g @nrwl/react:library with vite as bundler and jest as test runner fails
2 participants